Unverified Commit 56ad362c by Wolfgang Bumiller Committed by Christian Brauner

attach: use move_fd in lxc_proc_close_ns_fd

Previously this set `ctx->ns_fd[*]` to `-EBADF` until commit fd2a88b1 ("attach: cleanup macros lxc_proc_close_ns_fd", but there are some code paths where we call this before later calling `lxc_proc_put_context_info` which would call this function again with the file descriptors still unchanged. Signed-off-by: 's avatarWolfgang Bumiller <w.bumiller@proxmox.com>
parent 801e1da4
...@@ -126,7 +126,7 @@ static struct lxc_proc_context_info *lxc_proc_get_context_info(pid_t pid) ...@@ -126,7 +126,7 @@ static struct lxc_proc_context_info *lxc_proc_get_context_info(pid_t pid)
static inline void lxc_proc_close_ns_fd(struct lxc_proc_context_info *ctx) static inline void lxc_proc_close_ns_fd(struct lxc_proc_context_info *ctx)
{ {
for (int i = 0; i < LXC_NS_MAX; i++) { for (int i = 0; i < LXC_NS_MAX; i++) {
__do_close_prot_errno int fd = ctx->ns_fd[i]; __do_close_prot_errno int fd = move_fd(ctx->ns_fd[i]);
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment