conf: expand shmounts lxc.mount.auto option

Allow users to specify a path in the container they want to use. This will help LXD. Needed-by: https://github.com/lxc/lxd/issues/5227Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: expand shmounts lxc.mount.auto option
594426ca · Christian Brauner · Stéphane Graber · 007ef61a · 594426ca
Unverified Commit 594426ca authored Oct 30, 2018 by Christian Brauner Committed by Stéphane Graber Nov 01, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 11 additions and 5 deletions

confile.c src/lxc/confile.c +11 -5

No files found.
--- a/src/lxc/confile.c
+++ b/src/lxc/confile.c
@@ -1788,18 +1788,24 @@ static int set_config_mount_auto(const char *key, const char *value,
 		lxc_conf->auto_mounts |= allowed_auto_mounts[i].flag;

 		if (is_shmounts) {
-			lxc_conf->shmount.path_host = strdup(token + STRLITERALLEN("shmounts:"));
-			if (!lxc_conf->shmount.path_host) {
+			char *slide = token + STRLITERALLEN("shmounts:");
+
+			if (*slide == '\0') {
 				SYSERROR("Failed to copy shmounts host path");
 				goto on_error;
 			}

-			if (strcmp(lxc_conf->shmount.path_host, "") == 0) {
-				ERROR("Invalid shmounts path: empty");
+			lxc_conf->shmount.path_host = strdup(slide);
+			if (!lxc_conf->shmount.path_host) {
+				SYSERROR("Failed to copy shmounts host path");
 				goto on_error;
 			}

-			lxc_conf->shmount.path_cont = strdup("/dev/.lxc-mounts");
+			slide = strchr(slide, ':');
+			if (!slide || *(++slide) == '\0')
+				slide = "/dev/.lxc-mounts";
+
+			lxc_conf->shmount.path_cont = strdup(slide);
 			if(!lxc_conf->shmount.path_cont) {
 				SYSERROR("Failed to copy shmounts container path");
 				goto on_error;