Skip to content

L
lxc
Unverified Commit 612e48a3 by Christian Brauner Committed by GitHub
Options

Merge pull request #2999 from rikardfalkeborn/fix-realloc-memleak-proctitle

initutils: Fix memleak on realloc failure
parents 7d4188ce e1d43053
Showing with 5 additions and 3 deletions
src/lxc/initutils.c
...@@ -242,7 +242,7 @@ int setproctitle(char *title) ...@@ -242,7 +242,7 @@ int setproctitle(char *title)
{ {
__do_fclose FILE *f = NULL; __do_fclose FILE *f = NULL;
int i, fd, len; int i, fd, len;
char *buf_ptr; char *buf_ptr, *tmp_proctitle;
char buf[LXC_LINELEN]; char buf[LXC_LINELEN];
int ret = 0; int ret = 0;
ssize_t bytes_read = 0; ssize_t bytes_read = 0;
...@@ -305,10 +305,12 @@ int setproctitle(char *title) ...@@ -305,10 +305,12 @@ int setproctitle(char *title)
* want to have room for it. */ * want to have room for it. */
len = strlen(title) + 1; len = strlen(title) + 1;
proctitle = realloc(proctitle, len); tmp_proctitle = realloc(proctitle, len);
if (!proctitle) if (!tmp_proctitle)
return -1; return -1;
proctitle = tmp_proctitle;
arg_start = (unsigned long)proctitle; arg_start = (unsigned long)proctitle;
arg_end = arg_start + len; arg_end = arg_start + len;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment