coverity: fix resource leak

also fix the check if the string will fit the local buffer Signed-off-by: Dwight Engen <dwight.engen@oracle.com> Acked-by: Stéphane Graber <stgraber@ubuntu.com>

coverity: fix resource leak
684efc5e · Dwight Engen · Stéphane Graber · 77e22991 · 684efc5e
Commit 684efc5e authored Feb 14, 2014 by Dwight Engen Committed by Stéphane Graber Feb 14, 2014
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

cgmanager.c src/lxc/cgmanager.c +3 -1

No files found.
--- a/src/lxc/cgmanager.c
+++ b/src/lxc/cgmanager.c
@@ -422,8 +422,10 @@ static inline bool cgm_create(void *hdata)
 	tmp = lxc_string_replace("%n", d->name, d->cgroup_pattern);
 	if (!tmp)
 		return false;
-	if (strlen(tmp) > MAXPATHLEN)
+	if (strlen(tmp) >= MAXPATHLEN) {
+		free(tmp);
 		return false;
+	}
 	strcpy(result, tmp);
 	baselen = strlen(result);
 	free(tmp);