don't compare unsigned values as negative ones

Instead, check that the result is larger than its parts. Signed-off-by: Tycho Andersen <tycho.andersen@canonical.com> Acked-by: Stéphane Graber <stgraber@ubuntu.com>

don't compare unsigned values as negative ones
69f97e3c · Tycho Andersen · Stéphane Graber · e97aa817 · 69f97e3c
Commit 69f97e3c authored Apr 13, 2015 by Tycho Andersen Committed by Stéphane Graber Apr 13, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

utils.c src/lxc/utils.c +3 -2

No files found.
--- a/src/lxc/utils.c
+++ b/src/lxc/utils.c
@@ -1645,12 +1645,13 @@ int setproctitle(char *title)
 			env_start = env_end;
 		}

+		arg_end = arg_start + len;
+
 		/* check overflow */
-		if (arg_start + len < 0) {
+		if (arg_end < len || arg_end < arg_start) {
 			return -1;
 		}

-		arg_end = arg_start + len;
 	}

 	strcpy((char*)arg_start, title);