storage/dir: use clear error messages

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage/dir: use clear error messages
6cf21d91 · Christian Brauner · 4881d999 · 6cf21d91
Unverified Commit 6cf21d91 authored Apr 28, 2021 by Christian Brauner
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 4 deletions

dir.c src/lxc/storage/dir.c +7 -4

No files found.
--- a/src/lxc/storage/dir.c
+++ b/src/lxc/storage/dir.c
@@ -133,11 +133,14 @@ int dir_mount(struct lxc_storage *bdev)
 	int ret;
 	const char *src;

-	if (strcmp(bdev->type, "dir"))
-		return -22;
+	if (!strequal(bdev->type, "dir"))
+		return syserror_set(-EINVAL, "Invalid storage driver");

-	if (!bdev->src || !bdev->dest)
-		return -22;
+	if (is_empty_string(bdev->src))
+		return syserror_set(-EINVAL, "Missing rootfs path");
+
+	if (is_empty_string(bdev->dest))
+		return syserror_set(-EINVAL, "Missing target mountpoint");

 	src = lxc_storage_get_path(bdev->src, bdev->type);