start: don't return false when the container's init exits nonzero

This seems slightly counter-intuitive, but IMO it's what we want. Basically, ->start() should succeed if the container is spawned correctly (similar to how golang's exec.Cmd.Start() returns nil if the thing spawns correctly), and users can check error_num (i.e. golang's exec.Cmd.Wait()) to see how it exited. This preserves previous behavior, which basically was that start was always successful if the thing actually launched. Since we never kept track of exit codes, this would always succeed too. Now that we do, it doesn't, and this change is required. Signed-off-by: Tycho Andersen <tycho@tycho.ws>

start: don't return false when the container's init exits nonzero
6d88f7ea · Tycho Andersen · Christian Brauner · 50cbe5eb · 6d88f7ea
Unverified Commit 6d88f7ea authored Jan 19, 2018 by Tycho Andersen Committed by Christian Brauner Jan 19, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

start.c src/lxc/start.c +1 -1

No files found.
--- a/src/lxc/start.c
+++ b/src/lxc/start.c
@@ -1796,7 +1796,7 @@ int __lxc_start(const char *name, struct lxc_handler *handler,
 	}

 	lxc_monitor_send_exit_code(name, status, handler->lxcpath);
-	err =  lxc_error_set_and_log(handler->pid, status);
+	lxc_error_set_and_log(handler->pid, status);

 out_fini:
 	lxc_delete_network(handler);