Avoid risk of "too far memory read"

As we call "lxc_add_state_client(fd, handler, (lxc_state_t *)req->data)" which supposes that the last parameter is a table of MAX_STATE entries when calling memcpy(): memcpy(newclient->states, states, sizeof(newclient->states)) Signed-off-by: Rachid Koucha <rachid.koucha@gmail.com>

Avoid risk of "too far memory read"
71fc9c04 · Rachid Koucha · GitHub · 81f22990 · 71fc9c04
Unverified Commit 71fc9c04 authored Jan 27, 2019 by Rachid Koucha Committed by GitHub Jan 27, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

commands.c src/lxc/commands.c +1 -1

No files found.
--- a/src/lxc/commands.c
+++ b/src/lxc/commands.c
@@ -896,7 +896,7 @@ static int lxc_cmd_add_state_client_callback(int fd, struct lxc_cmd_req *req,
 	if (req->datalen < 0)
 		goto reap_client_fd;

-	if (req->datalen > (sizeof(lxc_state_t) * MAX_STATE))
+	if (req->datalen != (sizeof(lxc_state_t) * MAX_STATE))
 		goto reap_client_fd;

 	if (!req->data)