cgroups: please compilers

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroups: please compilers
7457a8b8 · Christian Brauner · Stéphane Graber · cafffc3d · 7457a8b8
Unverified Commit 7457a8b8 authored Mar 28, 2020 by Christian Brauner Committed by Stéphane Graber Mar 28, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

cgfsng.c src/lxc/cgroups/cgfsng.c +4 -2

No files found.
--- a/src/lxc/cgroups/cgfsng.c
+++ b/src/lxc/cgroups/cgfsng.c
@@ -2085,8 +2085,10 @@ static int cgroup_attach_leaf(const struct lxc_conf *conf, int unified_fd, pid_t
 		char attach_cgroup[STRLITERALLEN(".lxc-1000/cgroup.procs") + 1];
 		char *slash;

-		snprintf(attach_cgroup, STRLITERALLEN(".lxc-%d/cgroup.procs"),
-			 ".lxc-%d/cgroup.procs", idx);
+		ret = snprintf(attach_cgroup, sizeof(attach_cgroup), ".lxc-%d/cgroup.procs", idx);
+		if (ret < 0 || (size_t)ret >= sizeof(attach_cgroup))
+			return ret_errno(EIO);
+
 		slash = &attach_cgroup[ret] - STRLITERALLEN("/cgroup.procs");
 		*slash = '\0';