Skip to content

L
lxc
Unverified Commit 82057b13 by Christian Brauner Committed by Stéphane Graber
Options

rexec: free argv array on failure

Fixes: Coverity 1461736. Signed-off-by: 's avatarChristian Brauner <christian.brauner@ubuntu.com>
parent 264d40e5
Showing with 3 additions and 5 deletions
src/lxc/rexec.c
...@@ -169,13 +169,12 @@ extern char **environ; ...@@ -169,13 +169,12 @@ extern char **environ;
int lxc_rexec(const char *memfd_name) int lxc_rexec(const char *memfd_name)
{ {
__do_free_string_list char **argv = NULL;
int ret; int ret;
char **argv = NULL;
ret = is_memfd(); ret = is_memfd();
if (ret < 0 && ret == -ENOTRECOVERABLE) { if (ret < 0 && ret == -ENOTRECOVERABLE) {
fprintf(stderr, fprintf(stderr, "%s - Failed to determine whether this is a memfd\n",
"%s - Failed to determine whether this is a memfd\n",
strerror(errno)); strerror(errno));
return -1; return -1;
} else if (ret > 0) { } else if (ret > 0) {
...@@ -184,8 +183,7 @@ int lxc_rexec(const char *memfd_name) ...@@ -184,8 +183,7 @@ int lxc_rexec(const char *memfd_name)
ret = parse_argv(&argv); ret = parse_argv(&argv);
if (ret < 0) { if (ret < 0) {
fprintf(stderr, fprintf(stderr, "%s - Failed to parse command line parameters\n",
"%s - Failed to parse command line parameters\n",
strerror(errno)); strerror(errno));
return -1; return -1;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment