Commit 8523344a by hn

fix: unprivileged veth devices (e.g. vethFWABHX) never contain 'Z' character in…

fix: unprivileged veth devices (e.g. vethFWABHX) never contain 'Z' character in the randomly generated device name part because for modulo one does not need to substract 1 from strlen(). Signed-off-by: 's avatarHajo Noerenberg <hajo-github@noerenberg.de>
parent 688e8982
...@@ -1982,9 +1982,9 @@ char *lxc_mkifname(char *template) ...@@ -1982,9 +1982,9 @@ char *lxc_mkifname(char *template)
for (i = 0; i < strlen(name); i++) { for (i = 0; i < strlen(name); i++) {
if (name[i] == 'X') { if (name[i] == 'X') {
#ifdef HAVE_RAND_R #ifdef HAVE_RAND_R
name[i] = padchar[rand_r(&seed) % (strlen(padchar) - 1)]; name[i] = padchar[rand_r(&seed) % strlen(padchar)];
#else #else
name[i] = padchar[rand() % (strlen(padchar) - 1)]; name[i] = padchar[rand() % strlen(padchar)];
#endif #endif
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment