Unverified Commit 854ef04b by 0x0916 Committed by Stéphane Graber

remove the `__func__` macro

Our logging function will always spew out the function name. Signed-off-by: 's avatar0x0916 <w@laoqinren.net>
parent 24ff59af
...@@ -163,7 +163,7 @@ static int cgroup_rmdir(char *dirname) ...@@ -163,7 +163,7 @@ static int cgroup_rmdir(char *dirname)
dir = opendir(dirname); dir = opendir(dirname);
if (!dir) { if (!dir) {
ERROR("%s: failed to open %s", __func__, dirname); ERROR("Failed to open %s", dirname);
return -1; return -1;
} }
...@@ -188,7 +188,7 @@ static int cgroup_rmdir(char *dirname) ...@@ -188,7 +188,7 @@ static int cgroup_rmdir(char *dirname)
} }
ret = lstat(pathname, &mystat); ret = lstat(pathname, &mystat);
if (ret) { if (ret) {
SYSERROR("%s: failed to stat %s", __func__, pathname); SYSERROR("Failed to stat %s", pathname);
failed=1; failed=1;
if (!saved_errno) if (!saved_errno)
saved_errno = errno; saved_errno = errno;
...@@ -204,7 +204,7 @@ static int cgroup_rmdir(char *dirname) ...@@ -204,7 +204,7 @@ static int cgroup_rmdir(char *dirname)
} }
if (rmdir(dirname) < 0) { if (rmdir(dirname) < 0) {
SYSERROR("%s: failed to delete %s", __func__, dirname); SYSERROR("Failed to delete %s", dirname);
if (!saved_errno) if (!saved_errno)
saved_errno = errno; saved_errno = errno;
failed=1; failed=1;
...@@ -212,7 +212,7 @@ static int cgroup_rmdir(char *dirname) ...@@ -212,7 +212,7 @@ static int cgroup_rmdir(char *dirname)
ret = closedir(dir); ret = closedir(dir);
if (ret) { if (ret) {
SYSERROR("%s: failed to close directory %s", __func__, dirname); SYSERROR("Failed to close directory %s", dirname);
if (!saved_errno) if (!saved_errno)
saved_errno = errno; saved_errno = errno;
failed=1; failed=1;
...@@ -2204,7 +2204,7 @@ static int cgroup_read_from_file(const char *fn, char buf[], size_t bufsize) ...@@ -2204,7 +2204,7 @@ static int cgroup_read_from_file(const char *fn, char buf[], size_t bufsize)
return ret; return ret;
} }
/* Callers don't do this, but regression/sanity check */ /* Callers don't do this, but regression/sanity check */
ERROR("%s: was not expecting 0 bufsize", __func__); ERROR("was not expecting 0 bufsize");
return -1; return -1;
} }
buf[ret] = '\0'; buf[ret] = '\0';
......
...@@ -384,7 +384,7 @@ static int do_chown_cgroup(const char *controller, const char *cgroup_path, ...@@ -384,7 +384,7 @@ static int do_chown_cgroup(const char *controller, const char *cgroup_path,
goto out; goto out;
} }
if (send_creds(sv[0], getpid(), getuid(), getgid())) { if (send_creds(sv[0], getpid(), getuid(), getgid())) {
SYSERROR("%s: Error sending pid over SCM_CREDENTIAL", __func__); SYSERROR("Error sending pid over SCM_CREDENTIAL");
goto out; goto out;
} }
fds.fd = sv[0]; fds.fd = sv[0];
...@@ -399,7 +399,7 @@ static int do_chown_cgroup(const char *controller, const char *cgroup_path, ...@@ -399,7 +399,7 @@ static int do_chown_cgroup(const char *controller, const char *cgroup_path,
goto out; goto out;
} }
if (send_creds(sv[0], getpid(), newuid, 0)) { if (send_creds(sv[0], getpid(), newuid, 0)) {
SYSERROR("%s: Error sending pid over SCM_CREDENTIAL", __func__); SYSERROR("Error sending pid over SCM_CREDENTIAL");
goto out; goto out;
} }
fds.fd = sv[0]; fds.fd = sv[0];
......
...@@ -3913,7 +3913,7 @@ int chown_mapped_root(char *path, struct lxc_conf *conf) ...@@ -3913,7 +3913,7 @@ int chown_mapped_root(char *path, struct lxc_conf *conf)
if (rootuid == geteuid()) { if (rootuid == geteuid()) {
// nothing to do // nothing to do
INFO("%s: container root is our uid; no need to chown" ,__func__); INFO("Container root is our uid; no need to chown");
return 0; return 0;
} }
......
...@@ -69,7 +69,7 @@ static int _recursive_rmdir(char *dirname, dev_t pdev, bool onedev) ...@@ -69,7 +69,7 @@ static int _recursive_rmdir(char *dirname, dev_t pdev, bool onedev)
dir = opendir(dirname); dir = opendir(dirname);
if (!dir) { if (!dir) {
ERROR("%s: failed to open %s", __func__, dirname); ERROR("failed to open %s", dirname);
return -1; return -1;
} }
...@@ -93,7 +93,7 @@ static int _recursive_rmdir(char *dirname, dev_t pdev, bool onedev) ...@@ -93,7 +93,7 @@ static int _recursive_rmdir(char *dirname, dev_t pdev, bool onedev)
ret = lstat(pathname, &mystat); ret = lstat(pathname, &mystat);
if (ret) { if (ret) {
ERROR("%s: failed to stat %s", __func__, pathname); ERROR("Failed to stat %s", pathname);
failed = 1; failed = 1;
continue; continue;
} }
...@@ -109,20 +109,20 @@ static int _recursive_rmdir(char *dirname, dev_t pdev, bool onedev) ...@@ -109,20 +109,20 @@ static int _recursive_rmdir(char *dirname, dev_t pdev, bool onedev)
failed=1; failed=1;
} else { } else {
if (unlink(pathname) < 0) { if (unlink(pathname) < 0) {
SYSERROR("%s: failed to delete %s", __func__, pathname); SYSERROR("Failed to delete %s", pathname);
failed=1; failed=1;
} }
} }
} }
if (rmdir(dirname) < 0 && !btrfs_try_remove_subvol(dirname)) { if (rmdir(dirname) < 0 && !btrfs_try_remove_subvol(dirname)) {
ERROR("%s: failed to delete %s", __func__, dirname); ERROR("Failed to delete %s", dirname);
failed=1; failed=1;
} }
ret = closedir(dir); ret = closedir(dir);
if (ret) { if (ret) {
ERROR("%s: failed to close directory %s", __func__, dirname); ERROR("Failed to close directory %s", dirname);
failed=1; failed=1;
} }
...@@ -161,7 +161,7 @@ extern int lxc_rmdir_onedev(char *path) ...@@ -161,7 +161,7 @@ extern int lxc_rmdir_onedev(char *path)
if (lstat(path, &mystat) < 0) { if (lstat(path, &mystat) < 0) {
if (errno == ENOENT) if (errno == ENOENT)
return 0; return 0;
ERROR("%s: failed to stat %s", __func__, path); ERROR("Failed to stat %s", path);
return -1; return -1;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment