mkdir_p: account for '//foo/bar'

As Richard reported, dirname('//') returns //. But mkdir_p only stops when called with '/', resulting in infinite recursion when given a pathname '//foo/bar'. Reported-by: richard -rw- weinberger <richard.weinberger@gmail.com> Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>

mkdir_p: account for '//foo/bar'
883f4a1e · Serge Hallyn · ce4c4ca4 · 883f4a1e
Commit 883f4a1e authored Apr 16, 2013 by Serge Hallyn
Hide whitespace changes
Inline Side-by-side

Showing with 10 additions and 1 deletion

utils.c src/lxc/utils.c +10 -1

No files found.
--- a/src/lxc/utils.c
+++ b/src/lxc/utils.c
@@ -95,12 +95,21 @@ extern int get_u16(unsigned short *val, const char *arg, int base)
 	return 0;
 }

+static int is_all_slashes(char *path)
+{
+	while (*path && *path == '/')
+		path++;
+	if (*path)
+		return 0;
+	return 1;
+}
+
 extern int mkdir_p(char *dir, mode_t mode)
 {
        int ret;
        char *d;

-        if (!strcmp(dir, "/"))
+	if (is_all_slashes(dir))
                return 0;

        d = strdup(dir);