Skip to content

L
lxc
Commit 8a76c270 by Christian Brauner Committed by Stéphane Graber
Options

monitor: add more logging

Execing lxc-monitord is quite a crucial step so let's be very obsessive about logging possible errors to guide us in debugging. Signed-off-by: 's avatarChristian Brauner <christian.brauner@ubuntu.com>
parent 047fbbf5
Showing with 7 additions and 2 deletions
src/lxc/monitor.c
...@@ -349,18 +349,23 @@ int lxc_monitord_spawn(const char *lxcpath) ...@@ -349,18 +349,23 @@ int lxc_monitord_spawn(const char *lxcpath)
} }
lxc_check_inherited(NULL, true, pipefd[1]); lxc_check_inherited(NULL, true, pipefd[1]);
if (null_stdfds() < 0) if (null_stdfds() < 0) {
SYSERROR("Failed to dup2() standard file descriptors to /dev/null.");
exit(EXIT_FAILURE); exit(EXIT_FAILURE);
}
close(pipefd[0]); close(pipefd[0]);
ret = snprintf(pipefd_str, __INT_LEN, "%d", pipefd[1]); ret = snprintf(pipefd_str, __INT_LEN, "%d", pipefd[1]);
if (ret < 0 || ret >= __INT_LEN) if (ret < 0 || ret >= __INT_LEN) {
ERROR("Failed to create pid argument to pass to monitord.");
exit(EXIT_FAILURE); exit(EXIT_FAILURE);
}
DEBUG("Using pipe file descriptor %d for monitord.", pipefd[1]); DEBUG("Using pipe file descriptor %d for monitord.", pipefd[1]);
execvp(args[0], args); execvp(args[0], args);
ERROR("Failed to exec lxc-monitord.");
exit(EXIT_FAILURE); exit(EXIT_FAILURE);
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment