free struct dirent **namelist

Correct the way the struct dirent **namelist structure is freed. Signed-off-by: Clement Calmels <clement.calmels@fr.ibm.com> Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>

free struct dirent **namelist
8eec72f7 · Clement Calmels · Daniel Lezcano · 226a18d6 · 8eec72f7
Commit 8eec72f7 authored Jan 18, 2010 by Clement Calmels Committed by Daniel Lezcano Jan 18, 2010
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 5 deletions

parse.c src/lxc/parse.c +6 -5

No files found.
--- a/src/lxc/parse.c
+++ b/src/lxc/parse.c
@@ -43,7 +43,7 @@ int lxc_dir_for_each(const char *name, const char *directory,
 		     lxc_dir_cb callback, void *data)
 {
 	struct dirent **namelist;
-	int n;
+	int n, ret = 0;

 	n = scandir(directory, &namelist, dir_filter, alphasort);
 	if (n < 0) {
@@ -52,15 +52,16 @@ int lxc_dir_for_each(const char *name, const char *directory,
 	}

 	while (n--) {
-		if (callback(name, directory, namelist[n]->d_name, data)) {
+		if (!ret &&
+		    callback(name, directory, namelist[n]->d_name, data)) {
 			ERROR("callback failed");
-			free(namelist[n]);
-			return -1;
+			ret = -1;
 		}
 		free(namelist[n]);
 	}
+	free(namelist);

-	return 0;
+	return ret;
 }

 int lxc_file_for_each_line(const char *file, lxc_file_cb callback,