utils: defensive programming

If caller passed the size of array not string length, it is possible to be accessed out of bounds. Reorder conditions can prevent access invalid index of array. Signed-off-by: 2xsec <dh48.jeong@samsung.com>

utils: defensive programming
91d9cab6 · 2xsec · 22b67bfa · 91d9cab6
Unverified Commit 91d9cab6 authored Sep 04, 2018 by 2xsec
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

utils.c src/lxc/utils.c +2 -2

No files found.
--- a/src/lxc/utils.c
+++ b/src/lxc/utils.c
@@ -898,10 +898,10 @@ static char *get_nextpath(char *path, int *offsetp, int fulllen)
 	if (offset >= fulllen)
 		return NULL;

-	while (path[offset] != '\0' && offset < fulllen)
+	while (offset < fulllen && path[offset] != '\0')
 		offset++;

-	while (path[offset] == '\0' && offset < fulllen)
+	while (offset < fulllen && path[offset] == '\0')
 		offset++;

 	*offsetp = offset;