lxccontainer: use snprintf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: use snprintf()
92c2183c · Christian Brauner · Stéphane Graber · 01a066d3 · 92c2183c
Unverified Commit 92c2183c authored Jul 15, 2017 by Christian Brauner Committed by Stéphane Graber Aug 14, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

lxccontainer.c src/lxc/lxccontainer.c +5 -1

No files found.
--- a/src/lxc/lxccontainer.c
+++ b/src/lxc/lxccontainer.c
@@ -3319,7 +3319,11 @@ static struct lxc_container *do_lxcapi_clone(struct lxc_container *c, const char
 	saved_unexp_conf = NULL;
 	c->lxc_conf->unexpanded_len = saved_unexp_len;
-	sprintf(newpath, "%s/%s/rootfs", lxcpath, newname);
+	ret = snprintf(newpath, MAXPATHLEN, "%s/%s/rootfs", lxcpath, newname);
+	if (ret < 0 || ret >= MAXPATHLEN) {
+		SYSERROR("clone: failed making rootfs pathname");
+		goto out;
+	}
 	if (mkdir(newpath, 0755) < 0) {
 		SYSERROR("error creating %s", newpath);
 		goto out;