Merge pull request #3744 from evverx/oss-fuzz-32596

confile_utils: fix a signed integer overflow

Merge pull request #3744 from evverx/oss-fuzz-32596
94d05c50 · Christian Brauner · GitHub · db62570f · e6b35fbf · 94d05c50
Unverified Commit 94d05c50 authored Mar 28, 2021 by Christian Brauner Committed by GitHub Mar 28, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

confile_utils.c src/lxc/confile_utils.c +3 -3

No files found.
--- a/src/lxc/confile_utils.c
+++ b/src/lxc/confile_utils.c
@@ -1047,14 +1047,14 @@ static int rt_sig_num(const char *signame)
 		return ret_errno(EINVAL);

 	sig_n = sig_num(signame);
+	if (sig_n < 0 || sig_n > SIGRTMAX - SIGRTMIN)
+		return ret_errno(EINVAL);
+
 	if (rtmax)
 		sig_n = SIGRTMAX - sig_n;
 	else
 		sig_n = SIGRTMIN + sig_n;

-	if (sig_n > SIGRTMAX || sig_n < SIGRTMIN)
-		return ret_errno(EINVAL);
-
 	return sig_n;
 }