Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
L
lxc
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Chen Yisong
lxc
Commits
95d5b147
Commit
95d5b147
authored
Apr 14, 2015
by
Serge Hallyn
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "lxc-cmd-stop: two fixes"
This breaks code that depended on the monitor being fully dead before c->stop() returns. This reverts commit
62e04161
.
parent
d775f21b
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
9 deletions
+6
-9
commands.c
src/lxc/commands.c
+6
-9
No files found.
src/lxc/commands.c
View file @
95d5b147
...
...
@@ -608,13 +608,11 @@ int lxc_cmd_stop(const char *name, const char *lxcpath)
return
-
1
;
}
if
(
!
ret
)
{
WARN
(
"'%s' has stopped before replying with success"
,
name
);
return
-
1
;
}
if
(
cmd
.
rsp
.
ret
!=
0
)
{
ERROR
(
"Container %s:%s had an error stopping"
,
lxcpath
,
name
);
/* we do not expect any answer, because we wait for the connection to be
* closed
*/
if
(
ret
>
0
)
{
ERROR
(
"failed to stop '%s': %s"
,
name
,
strerror
(
-
cmd
.
rsp
.
ret
));
return
-
1
;
}
...
...
@@ -639,12 +637,11 @@ static int lxc_cmd_stop_callback(int fd, struct lxc_cmd_req *req,
* deadlock us
*/
if
(
cgroup_unfreeze
(
handler
))
goto
out
;
return
0
;
ERROR
(
"Failed to unfreeze %s:%s"
,
handler
->
lxcpath
,
handler
->
name
);
rsp
.
ret
=
-
1
;
}
out:
return
lxc_cmd_rsp_send
(
fd
,
&
rsp
);
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment