Unverified Commit 9c0e2551 by Christian Brauner Committed by Stéphane Graber

rexec: avoid double-close

Fixes: Coverity 1461721. Signed-off-by: 's avatarChristian Brauner <christian.brauner@ubuntu.com>
parent bc15baac
...@@ -88,7 +88,7 @@ static int is_memfd(void) ...@@ -88,7 +88,7 @@ static int is_memfd(void)
static void lxc_rexec_as_memfd(char **argv, char **envp, const char *memfd_name) static void lxc_rexec_as_memfd(char **argv, char **envp, const char *memfd_name)
{ {
__do_close int execfd = -EBADF, fd = -EBADF, memfd = -EBADF, __do_close int execfd = -EBADF, fd = -EBADF, memfd = -EBADF,
tmpfd = -EBADF; tmpfd = -EBADF;
int ret; int ret;
ssize_t bytes_sent = 0; ssize_t bytes_sent = 0;
struct stat st = {0}; struct stat st = {0};
...@@ -143,7 +143,7 @@ static void lxc_rexec_as_memfd(char **argv, char **envp, const char *memfd_name) ...@@ -143,7 +143,7 @@ static void lxc_rexec_as_memfd(char **argv, char **envp, const char *memfd_name)
if (fcntl(memfd, F_ADD_SEALS, LXC_MEMFD_REXEC_SEALS)) if (fcntl(memfd, F_ADD_SEALS, LXC_MEMFD_REXEC_SEALS))
return; return;
execfd = memfd; execfd = move_fd(memfd);
} else { } else {
char procfd[LXC_PROC_PID_FD_LEN]; char procfd[LXC_PROC_PID_FD_LEN];
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment