Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
L
lxc
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Chen Yisong
lxc
Commits
9eaf8a59
Commit
9eaf8a59
authored
Oct 04, 2014
by
Sergio Jimenez
Committed by
Stéphane Graber
Oct 27, 2014
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed mismatch on ipvX gateway
Signed-off-by:
Sergio Jimenez
<
tripledes@gmail.com
>
Acked-by:
Stéphane Graber
<
stgraber@ubuntu.com
>
parent
df7216f6
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
31 additions
and
7 deletions
+31
-7
conf.c
src/lxc/conf.c
+2
-2
confile.c
src/lxc/confile.c
+5
-5
get_item.c
src/tests/get_item.c
+24
-0
No files found.
src/lxc/conf.c
View file @
9eaf8a59
...
@@ -4318,12 +4318,12 @@ int lxc_clear_nic(struct lxc_conf *c, const char *key)
...
@@ -4318,12 +4318,12 @@ int lxc_clear_nic(struct lxc_conf *c, const char *key)
free
(
netdev
->
mtu
);
free
(
netdev
->
mtu
);
netdev
->
mtu
=
NULL
;
netdev
->
mtu
=
NULL
;
}
}
}
else
if
(
strcmp
(
p1
,
".ipv4
_
gateway"
)
==
0
)
{
}
else
if
(
strcmp
(
p1
,
".ipv4
.
gateway"
)
==
0
)
{
if
(
netdev
->
ipv4_gateway
)
{
if
(
netdev
->
ipv4_gateway
)
{
free
(
netdev
->
ipv4_gateway
);
free
(
netdev
->
ipv4_gateway
);
netdev
->
ipv4_gateway
=
NULL
;
netdev
->
ipv4_gateway
=
NULL
;
}
}
}
else
if
(
strcmp
(
p1
,
".ipv6
_
gateway"
)
==
0
)
{
}
else
if
(
strcmp
(
p1
,
".ipv6
.
gateway"
)
==
0
)
{
if
(
netdev
->
ipv6_gateway
)
{
if
(
netdev
->
ipv6_gateway
)
{
free
(
netdev
->
ipv6_gateway
);
free
(
netdev
->
ipv6_gateway
);
netdev
->
ipv6_gateway
=
NULL
;
netdev
->
ipv6_gateway
=
NULL
;
...
...
src/lxc/confile.c
View file @
9eaf8a59
...
@@ -452,9 +452,9 @@ extern int lxc_list_nicconfigs(struct lxc_conf *c, const char *key,
...
@@ -452,9 +452,9 @@ extern int lxc_list_nicconfigs(struct lxc_conf *c, const char *key,
strprint
(
retv
,
inlen
,
"hwaddr
\n
"
);
strprint
(
retv
,
inlen
,
"hwaddr
\n
"
);
strprint
(
retv
,
inlen
,
"mtu
\n
"
);
strprint
(
retv
,
inlen
,
"mtu
\n
"
);
strprint
(
retv
,
inlen
,
"ipv6
\n
"
);
strprint
(
retv
,
inlen
,
"ipv6
\n
"
);
strprint
(
retv
,
inlen
,
"ipv6
_
gateway
\n
"
);
strprint
(
retv
,
inlen
,
"ipv6
.
gateway
\n
"
);
strprint
(
retv
,
inlen
,
"ipv4
\n
"
);
strprint
(
retv
,
inlen
,
"ipv4
\n
"
);
strprint
(
retv
,
inlen
,
"ipv4
_
gateway
\n
"
);
strprint
(
retv
,
inlen
,
"ipv4
.
gateway
\n
"
);
}
}
switch
(
netdev
->
type
)
{
switch
(
netdev
->
type
)
{
case
LXC_NET_VETH
:
case
LXC_NET_VETH
:
...
@@ -2135,7 +2135,7 @@ static int lxc_get_auto_mounts(struct lxc_conf *c, char *retv, int inlen)
...
@@ -2135,7 +2135,7 @@ static int lxc_get_auto_mounts(struct lxc_conf *c, char *retv, int inlen)
/*
/*
* lxc.network.0.XXX, where XXX can be: name, type, link, flags, type,
* lxc.network.0.XXX, where XXX can be: name, type, link, flags, type,
* macvlan.mode, veth.pair, vlan, ipv4, ipv6, script.up, hwaddr, mtu,
* macvlan.mode, veth.pair, vlan, ipv4, ipv6, script.up, hwaddr, mtu,
* ipv4
_gateway, ipv6_gateway. ipvX_
gateway can return 'auto' instead
* ipv4
.gateway, ipv6.gateway. ipvX.
gateway can return 'auto' instead
* of an address. ipv4 and ipv6 return lists (newline-separated).
* of an address. ipv4 and ipv6 return lists (newline-separated).
* things like veth.pair return '' if invalid (i.e. if called for vlan
* things like veth.pair return '' if invalid (i.e. if called for vlan
* type).
* type).
...
@@ -2204,7 +2204,7 @@ static int lxc_get_item_nic(struct lxc_conf *c, char *retv, int inlen,
...
@@ -2204,7 +2204,7 @@ static int lxc_get_item_nic(struct lxc_conf *c, char *retv, int inlen,
if
(
netdev
->
type
==
LXC_NET_VLAN
)
{
if
(
netdev
->
type
==
LXC_NET_VLAN
)
{
strprint
(
retv
,
inlen
,
"%d"
,
netdev
->
priv
.
vlan_attr
.
vid
);
strprint
(
retv
,
inlen
,
"%d"
,
netdev
->
priv
.
vlan_attr
.
vid
);
}
}
}
else
if
(
strcmp
(
p1
,
"ipv4
_
gateway"
)
==
0
)
{
}
else
if
(
strcmp
(
p1
,
"ipv4
.
gateway"
)
==
0
)
{
if
(
netdev
->
ipv4_gateway_auto
)
{
if
(
netdev
->
ipv4_gateway_auto
)
{
strprint
(
retv
,
inlen
,
"auto"
);
strprint
(
retv
,
inlen
,
"auto"
);
}
else
if
(
netdev
->
ipv4_gateway
)
{
}
else
if
(
netdev
->
ipv4_gateway
)
{
...
@@ -2220,7 +2220,7 @@ static int lxc_get_item_nic(struct lxc_conf *c, char *retv, int inlen,
...
@@ -2220,7 +2220,7 @@ static int lxc_get_item_nic(struct lxc_conf *c, char *retv, int inlen,
inet_ntop
(
AF_INET
,
&
i
->
addr
,
buf
,
sizeof
(
buf
));
inet_ntop
(
AF_INET
,
&
i
->
addr
,
buf
,
sizeof
(
buf
));
strprint
(
retv
,
inlen
,
"%s/%d
\n
"
,
buf
,
i
->
prefix
);
strprint
(
retv
,
inlen
,
"%s/%d
\n
"
,
buf
,
i
->
prefix
);
}
}
}
else
if
(
strcmp
(
p1
,
"ipv6
_
gateway"
)
==
0
)
{
}
else
if
(
strcmp
(
p1
,
"ipv6
.
gateway"
)
==
0
)
{
if
(
netdev
->
ipv6_gateway_auto
)
{
if
(
netdev
->
ipv6_gateway_auto
)
{
strprint
(
retv
,
inlen
,
"auto"
);
strprint
(
retv
,
inlen
,
"auto"
);
}
else
if
(
netdev
->
ipv6_gateway
)
{
}
else
if
(
netdev
->
ipv6_gateway
)
{
...
...
src/tests/get_item.c
View file @
9eaf8a59
...
@@ -237,6 +237,30 @@ int main(int argc, char *argv[])
...
@@ -237,6 +237,30 @@ int main(int argc, char *argv[])
goto
out
;
goto
out
;
}
}
if
(
!
c
->
set_config_item
(
c
,
"lxc.network.ipv4.gateway"
,
"10.2.3.254"
))
{
fprintf
(
stderr
,
"%d: failed to set ipv4.gateway
\n
"
,
__LINE__
);
ret
=
1
;
goto
out
;
}
ret
=
c
->
get_config_item
(
c
,
"lxc.network.0.ipv4.gateway"
,
v2
,
255
);
if
(
ret
<=
0
)
{
fprintf
(
stderr
,
"%d: lxc.network.0.ipv4.gateway returned %d
\n
"
,
__LINE__
,
ret
);
ret
=
1
;
goto
out
;
}
if
(
!
c
->
clear_config_item
(
c
,
"lxc.network.0.ipv4.gateway"
))
{
fprintf
(
stderr
,
"%d: failed clearing ipv4.gateway
\n
"
,
__LINE__
);
ret
=
1
;
goto
out
;
}
ret
=
c
->
get_config_item
(
c
,
"lxc.network.0.ipv4.gateway"
,
v2
,
255
);
if
(
ret
!=
0
)
{
fprintf
(
stderr
,
"%d: after clearing ipv4.gateway get_item(lxc.network.0.ipv4.gateway returned %d
\n
"
,
__LINE__
,
ret
);
ret
=
1
;
goto
out
;
}
ret
=
c
->
get_config_item
(
c
,
"lxc.network.0.link"
,
v2
,
255
);
ret
=
c
->
get_config_item
(
c
,
"lxc.network.0.link"
,
v2
,
255
);
if
(
ret
<
0
)
{
if
(
ret
<
0
)
{
fprintf
(
stderr
,
"%d: get_config_item returned %d
\n
"
,
__LINE__
,
ret
);
fprintf
(
stderr
,
"%d: get_config_item returned %d
\n
"
,
__LINE__
,
ret
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment