Fix lxc-netstat -- argument processing

Commit 21e487f2 introduced the use of getopt, but getopt will fail when it sees arguments meant for netstat that are not in [short|long]options. There should not be any ambiguity about arguments with the same letter: those to the left of the -- are destined for lxc-netstat and those to the right for the real netstat, which the original code handles by shifting out all arguments it recognizes before the -- is hit. Signed-off-by: Dwight Engen <dwight.engen@oracle.com> Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>

Fix lxc-netstat -- argument processing
a24c5a40 · Dwight Engen · Daniel Lezcano · a3812bf0 · a24c5a40
Commit a24c5a40 authored Oct 31, 2012 by Dwight Engen Committed by Daniel Lezcano Oct 31, 2012
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 12 deletions

lxc-netstat.in src/lxc/lxc-netstat.in +1 -12

No files found.
--- a/src/lxc/lxc-netstat.in
+++ b/src/lxc/lxc-netstat.in
@@ -67,19 +67,8 @@ get_parent_cgroup()
 	done
 }

-shortoptions='hn:'
-longoptions='help,name:,exec'
-
-getopt=$(getopt -o $shortoptions --longoptions  $longoptions -- "$@")
-if [ $? != 0 ]; then
-    usage
-    exit 1;
-fi
-
 exec=""

-eval set -- "$getopt"
-
 while true; do
 	case $1 in
 		-h|--help)
@@ -91,7 +80,7 @@ while true; do
 		--)
 			shift; break;;
 		*)
-			break;
+			break;;
 	esac
 done