parse: do not mask failed parse

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

parse: do not mask failed parse
a284d9d5 · Christian Brauner · 929a141a · a284d9d5
Unverified Commit a284d9d5 authored Oct 08, 2018 by Christian Brauner
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

parse.c src/lxc/parse.c +4 -2

No files found.
--- a/src/lxc/parse.c
+++ b/src/lxc/parse.c
@@ -111,9 +111,11 @@ int lxc_file_for_each_line_mmap(const char *file, lxc_file_cb callback, void *da
 	}

 on_error:
-	ret = lxc_strmunmap(buf, st.st_size);
-	if (ret < 0)
+	if (lxc_strmunmap(buf, st.st_size) < 0) {
 		SYSERROR("Failed to unmap config file \"%s\"", file);
+		if (ret == 0)
+			ret = -1;
+	}

 	saved_errno = errno;
 	close(fd);