console: do not allow non-pty devices on open()

We don't allow non-pty devices anyway so don't let open() create unneeded files. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

console: do not allow non-pty devices on open()
a63fade5 · Christian Brauner · 1cc8bd4b · a63fade5
Unverified Commit a63fade5 authored Dec 26, 2017 by Christian Brauner
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

console.c src/lxc/console.c +2 -2

No files found.
--- a/src/lxc/console.c
+++ b/src/lxc/console.c
@@ -518,9 +518,9 @@ static int lxc_console_peer_default(struct lxc_console *console)
 		goto out;
 	}
-	console->peer = lxc_unpriv(open(path, O_CLOEXEC | O_RDWR | O_CREAT | O_APPEND, 0600));
+	console->peer = lxc_unpriv(open(path, O_RDWR | O_CLOEXEC));
 	if (console->peer < 0) {
-		ERROR("failed to open \"%s\": %s", path, strerror(errno));
+		ERROR("Failed to open \"%s\": %s", path, strerror(errno));
 		return -ENOTTY;
 	}
 	DEBUG("using \"%s\" as peer tty device", path);