coverity: fix dereference NULL return value

also break once we have found root, no need to search the rest of the mounts Changelog: May 6: Serge: don't add the break. (see m-l) Signed-off-by: Dwight Engen <dwight.engen@oracle.com> Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>

coverity: fix dereference NULL return value
ab81cef0 · Dwight Engen · Serge Hallyn · 7c7ec7a8 · ab81cef0
Commit ab81cef0 authored May 03, 2013 by Dwight Engen Committed by Serge Hallyn May 06, 2013
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

conf.c src/lxc/conf.c +2 -1

No files found.
--- a/src/lxc/conf.c
+++ b/src/lxc/conf.c
@@ -1067,10 +1067,11 @@ int detect_shared_rootfs(void)
 		if (strcmp(p+1, "/") == 0) {
 			// this is '/'.  is it shared?
 			p = index(p2+1, ' ');
-			if (strstr(p, "shared:")) {
+			if (p && strstr(p, "shared:")) {
 				fclose(f);
 				return 1;
 			}
+			break;
 		}
 	}
 	fclose(f);