coverity: Check return value of setenv

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com> Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>

coverity: Check return value of setenv
acd4922e · Stéphane Graber · 1e985428 · acd4922e
Commit acd4922e authored Feb 14, 2014 by Stéphane Graber
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

attach.c src/lxc/attach.c +4 -2

No files found.
--- a/src/lxc/attach.c
+++ b/src/lxc/attach.c
@@ -317,8 +317,10 @@ static int lxc_attach_set_environment(enum lxc_attach_env_policy_t policy, char*
 		if (extra_keep_store) {
 			size_t i;
 			for (i = 0; extra_keep[i]; i++) {
-				if (extra_keep_store[i])
-					setenv(extra_keep[i], extra_keep_store[i], 1);
+				if (extra_keep_store[i]) {
+					if (setenv(extra_keep[i], extra_keep_store[i], 1) < 0)
+						SYSERROR("Unable to set environment variable");
+				}
 				free(extra_keep_store[i]);
 			}
 			free(extra_keep_store);