coverity: #1425748

Time of check time of use Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

coverity: #1425748
b29e05d6 · Christian Brauner · 48cfd5db · b29e05d6
Unverified Commit b29e05d6 authored Jun 14, 2018 by Christian Brauner
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 4 deletions

conf.c src/lxc/conf.c +4 -4

No files found.
--- a/src/lxc/conf.c
+++ b/src/lxc/conf.c
@@ -1581,13 +1581,13 @@ static int lxc_setup_devpts(struct lxc_conf *conf)
 	DEBUG("Mount new devpts instance with options \"%s\"", devpts_mntopts);
 	/* Remove any pre-existing /dev/ptmx file. */
-	ret = access("/dev/ptmx", F_OK);
+	ret = remove("/dev/ptmx");
-	if (!ret) {
+	if (ret < 0) {
-		ret = remove("/dev/ptmx");
+		if (errno != ENOENT) {
-		if (ret < 0) {
 			SYSERROR("Failed to remove existing \"/dev/ptmx\" file");
 			return -1;
 		}
+	} else {
 		DEBUG("Removed existing \"/dev/ptmx\" file");
 	}