conf: fix unchecked return value

Fixes: Coverity: 1465854 Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: fix unchecked return value
b41ff502 · Christian Brauner · 999f5140 · b41ff502
Unverified Commit b41ff502 authored Dec 09, 2020 by Christian Brauner
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

conf.c src/lxc/conf.c +3 -1

No files found.
--- a/src/lxc/conf.c
+++ b/src/lxc/conf.c
@@ -1201,7 +1201,9 @@ static int lxc_fill_autodev(const struct lxc_rootfs *rootfs)
 		}

 		/* Fallback to bind-mounting the device from the host. */
-		snprintf(hostpath, sizeof(hostpath), "/dev/%s", device->name);
+		ret = snprintf(hostpath, sizeof(hostpath), "/dev/%s", device->name);
+		if (ret < 0 || (size_t)ret >= sizeof(hostpath))
+			return ret_errno(EIO);

 		ret = safe_mount_beneath_at(dev_dir_fd, hostpath, device->name, NULL, MS_BIND, NULL);
 		if (ret < 0) {