Merge pull request #2355 from 2xsec/master

network: fix socket handle leak

Merge pull request #2355 from 2xsec/master
b7184135 · Christian Brauner · GitHub · f1a571d6 · 87c6e5db · b7184135
Unverified Commit b7184135 authored May 28, 2018 by Christian Brauner Committed by GitHub May 28, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

network.c src/lxc/network.c +3 -1

No files found.
--- a/src/lxc/network.c
+++ b/src/lxc/network.c
@@ -2027,8 +2027,10 @@ int setup_private_host_hw_addr(char *veth1)
 		return -errno;

 	err = snprintf((char *)ifr.ifr_name, IFNAMSIZ, "%s", veth1);
-	if (err < 0 || (size_t)err >= IFNAMSIZ)
+	if (err < 0 || (size_t)err >= IFNAMSIZ) {
+		close(sockfd);
 		return -E2BIG;
+	}

 	err = ioctl(sockfd, SIOCGIFHWADDR, &ifr);
 	if (err < 0) {