netlink_open: close socket on error

All uses of netlink_open() assume that on error the nl_handler doesn't need to be closed, but some error cases happen after the socket was opened successfully and used to simply return -errno. Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>

netlink_open: close socket on error
b8b435e3 · Wolfgang Bumiller · Stéphane Graber · 3b860b72 · b8b435e3
Commit b8b435e3 authored Apr 06, 2016 by Wolfgang Bumiller Committed by Stéphane Graber Nov 17, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 18 additions and 8 deletions

nl.c src/lxc/nl.c +18 -8

No files found.
--- a/src/lxc/nl.c
+++ b/src/lxc/nl.c
@@ -265,6 +265,7 @@ extern int netlink_open(struct nl_handler *handler, int protocol)
 	socklen_t socklen;
 	int sndbuf = 32768;
 	int rcvbuf = 32768;
+	int err;
 	memset(handler, 0, sizeof(*handler));
@@ -274,11 +275,11 @@ extern int netlink_open(struct nl_handler *handler, int protocol)
 	if (setsockopt(handler->fd, SOL_SOCKET, SO_SNDBUF,
 		       &sndbuf, sizeof(sndbuf)) < 0)
-		return -errno;
+		goto err_with_errno;
 	if (setsockopt(handler->fd, SOL_SOCKET, SO_RCVBUF,
 		       &rcvbuf,sizeof(rcvbuf)) < 0)
-		return -errno;
+		goto err_with_errno;
 	memset(&handler->local, 0, sizeof(handler->local));
 	handler->local.nl_family = AF_NETLINK;
@@ -286,22 +287,31 @@ extern int netlink_open(struct nl_handler *handler, int protocol)
 	if (bind(handler->fd, (struct sockaddr*)&handler->local,
 		 sizeof(handler->local)) < 0)
-		return -errno;
+		goto err_with_errno;
 	socklen = sizeof(handler->local);
 	if (getsockname(handler->fd, (struct sockaddr*)&handler->local,
 			&socklen) < 0)
-		return -errno;
+		goto err_with_errno;
-	if (socklen != sizeof(handler->local))
+	if (socklen != sizeof(handler->local)) {
-		return -EINVAL;
+		err = -EINVAL;
+		goto errclose;
+	}
-	if (handler->local.nl_family != AF_NETLINK)
+	if (handler->local.nl_family != AF_NETLINK) {
-		return -EINVAL;
+		err = -EINVAL;
+		goto errclose;
+	}
 	handler->seq = time(NULL);
 	return 0;
+err_with_errno:
+	err = -errno;
+errclose:
+	close(handler->fd);
+	return err;
 }
 extern int netlink_close(struct nl_handler *handler)