Skip to content

L
lxc
Unverified Commit bc554fdf by Christian Brauner Committed by GitHub
Options

Merge pull request #3090 from Rachid-Koucha/patch-3

Suppress hardcoded table sizes
parents 9b017958 6da73634
Showing with 4 additions and 4 deletions
src/lxc/utils.c
...@@ -1171,8 +1171,8 @@ int safe_mount(const char *src, const char *dest, const char *fstype, ...@@ -1171,8 +1171,8 @@ int safe_mount(const char *src, const char *dest, const char *fstype,
if (srcfd < 0) if (srcfd < 0)
return srcfd; return srcfd;
ret = snprintf(srcbuf, 50, "/proc/self/fd/%d", srcfd); ret = snprintf(srcbuf, sizeof(srcbuf), "/proc/self/fd/%d", srcfd);
if (ret < 0 || ret > 50) { if (ret < 0 || ret >= (int)sizeof(srcbuf)) {
close(srcfd); close(srcfd);
ERROR("Out of memory"); ERROR("Out of memory");
return -EINVAL; return -EINVAL;
...@@ -1191,8 +1191,8 @@ int safe_mount(const char *src, const char *dest, const char *fstype, ...@@ -1191,8 +1191,8 @@ int safe_mount(const char *src, const char *dest, const char *fstype,
return destfd; return destfd;
} }
ret = snprintf(destbuf, 50, "/proc/self/fd/%d", destfd); ret = snprintf(destbuf, sizeof(destbuf), "/proc/self/fd/%d", destfd);
if (ret < 0 || ret > 50) { if (ret < 0 || ret >= (int)sizeof(destbuf)) {
if (srcfd != -1) if (srcfd != -1)
close(srcfd); close(srcfd);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment