When an item is added to an array, then the array is realloc()ed (to size+1),

and the item is copied (strdup()) to the array. Thus, when an item is removed from an array, memory allocated for that item should be freed, successive items should be left-shifted and the array realloc()ed again (size-1). Additional changes: - If strdup() fails in add_to_array(), then an array should be realloc()ed again to original size. - Initialize an array in list_all_containers(). Signed-off-by: Tomasz Blaszczak <tomasz.blaszczak@consult.red>

When an item is added to an array, then the array is realloc()ed (to size+1),
bc5f0449 · Tomasz Blaszczak · 5364ae41 · bc5f0449
Commit bc5f0449 authored Jun 23, 2021 by Tomasz Blaszczak
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

lxccontainer.c src/lxc/lxccontainer.c +1 -1

No files found.
--- a/src/lxc/lxccontainer.c
+++ b/src/lxc/lxccontainer.c
@@ -2326,7 +2326,7 @@ static bool remove_from_array(char ***names, char *cname, int size)
 		char **newnames = (char**)realloc(*names, (size-1) * sizeof(char *));
 		if (!newnames) {
 			ERROR("Out of memory");
-			return false;
+			return true;
 		}
 		*names = newnames;