Skip to content

L
lxc
Unverified Commit d3ccc04e by Christian Brauner
Options

coverity: #1425758

Time of check time of use Signed-off-by: 's avatarChristian Brauner <christian.brauner@ubuntu.com>
parent b29e05d6
Showing with 4 additions and 12 deletions
src/lxc/conf.c
...@@ -924,16 +924,9 @@ static int lxc_setup_ttys(struct lxc_conf *conf) ...@@ -924,16 +924,9 @@ static int lxc_setup_ttys(struct lxc_conf *conf)
/* If we populated /dev, then we need to create /* If we populated /dev, then we need to create
* /dev/ttyN * /dev/ttyN
*/ */
ret = access(path, F_OK); ret = mknod(path, S_IFREG | 0000, 0);
if (ret < 0) { if (ret < 0) /* this isn't fatal, continue */
ret = creat(path, 0660); ERROR("%s - Failed to create \"%s\"", strerror(errno), path);
if (ret < 0) {
SYSERROR("Failed to create \"%s\"", path);
/* this isn't fatal, continue */
} else {
close(ret);
}
}
ret = mount(tty->name, path, "none", MS_BIND, 0); ret = mount(tty->name, path, "none", MS_BIND, 0);
if (ret < 0) { if (ret < 0) {
...@@ -941,8 +934,7 @@ static int lxc_setup_ttys(struct lxc_conf *conf) ...@@ -941,8 +934,7 @@ static int lxc_setup_ttys(struct lxc_conf *conf)
continue; continue;
} }
DEBUG("Bind mounted \"%s\" onto \"%s\"", tty->name, DEBUG("Bind mounted \"%s\" onto \"%s\"", tty->name, path);
path);
} }
if (!append_ttyname(&conf->ttys.tty_names, tty->name)) { if (!append_ttyname(&conf->ttys.tty_names, tty->name)) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment