commands_utils: fix socket leak in when adding state client

If lxc_add_state_client() is called with the container already being in the desired state the client fd will never be closed and is leaking. This due to setting stay_connected in lxc_cmd for LXC_CMD_ADD_STATE_CLIENT. If the desired state isn't already achieved the client fd will later be closed by calling lxc_cmd_fd_cleanup() but in the other case the client configuration isn't added to the handlers state clients. So the client fd has to be closed explicitely. This is simply tested by starting container A and calling lxc-wait -n A -s RUNNING. Signed-off-by: Matthias Hardt <matthias.hardt@gmail.com>

commands_utils: fix socket leak in when adding state client
d7aa5552 · Matthias Hardt · d31059ef · d7aa5552
Unverified Commit d7aa5552 authored Mar 09, 2020 by Matthias Hardt
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 0 deletions

commands_utils.c src/lxc/commands_utils.c +1 -0

No files found.
--- a/src/lxc/commands_utils.c
+++ b/src/lxc/commands_utils.c
@@ -195,6 +195,7 @@ int lxc_add_state_client(int state_client_fd, struct lxc_handler *handler,
 		lxc_list_add_elem(tmplist, newclient);
 		lxc_list_add_tail(&handler->conf->state_clients, tmplist);
 	} else {
+		close(state_client_fd);
 		return state;
 	}