fix NULL dereference

lxc_console dereferences C, so we should check that it is not null and fail if it is. Reported-by: Coverity Signed-off-by: Tycho Andersen <tycho.andersen@canonical.com> Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>

fix NULL dereference
dcd1e262 · Tycho Andersen · Stéphane Graber · 284c4b01 · dcd1e262
Commit dcd1e262 authored Apr 13, 2015 by Tycho Andersen Committed by Stéphane Graber Apr 13, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

lxccontainer.c src/lxc/lxccontainer.c +5 -1

No files found.
--- a/src/lxc/lxccontainer.c
+++ b/src/lxc/lxccontainer.c
@@ -463,7 +463,11 @@ static int lxcapi_console(struct lxc_container *c, int ttynum, int stdinfd,
 {
 	int ret;
 	struct lxc_conf *old = current_config;
-	current_config = c ? c->lxc_conf : NULL;
+
+	if (!c)
+		return -1;
+
+	current_config = c->lxc_conf;
 	ret = lxc_console(c, ttynum, stdinfd, stdoutfd, stderrfd, escape);
 	current_config = old;
 	return ret;