Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
L
lxc
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Chen Yisong
lxc
Commits
dfb8c303
Unverified
Commit
dfb8c303
authored
Sep 09, 2017
by
Christian Brauner
Committed by
Stéphane Graber
Sep 24, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
conf: add userns_exec_full()
Closes #1800. Signed-off-by:
Christian Brauner
<
christian.brauner@ubuntu.com
>
parent
1da539b0
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
181 additions
and
2 deletions
+181
-2
conf.c
src/lxc/conf.c
+179
-2
conf.h
src/lxc/conf.h
+2
-0
No files found.
src/lxc/conf.c
View file @
dfb8c303
...
...
@@ -3816,8 +3816,7 @@ int userns_exec_1(struct lxc_conf *conf, int (*fn)(void *), void *data,
ret
=
lxc_map_ids
(
idmap
,
pid
);
if
(
ret
<
0
)
{
ERROR
(
"error setting up {g,u}id mappings for child process "
"
\"
%d
\"
"
,
pid
);
"
\"
%d
\"
"
,
pid
);
goto
on_error
;
}
...
...
@@ -3849,6 +3848,184 @@ on_error:
return
ret
;
}
int
userns_exec_full
(
struct
lxc_conf
*
conf
,
int
(
*
fn
)(
void
*
),
void
*
data
,
const
char
*
fn_name
)
{
pid_t
pid
;
uid_t
euid
,
egid
;
struct
userns_fn_data
d
;
int
p
[
2
];
struct
id_map
*
map
;
struct
lxc_list
*
cur
;
char
c
=
'1'
;
int
ret
=
-
1
;
struct
lxc_list
*
idmap
=
NULL
,
*
tmplist
=
NULL
;
struct
id_map
*
container_root_uid
=
NULL
,
*
container_root_gid
=
NULL
,
*
host_uid_map
=
NULL
,
*
host_gid_map
=
NULL
;
ret
=
pipe
(
p
);
if
(
ret
<
0
)
{
SYSERROR
(
"opening pipe"
);
return
-
1
;
}
d
.
fn
=
fn
;
d
.
fn_name
=
fn_name
;
d
.
arg
=
data
;
d
.
p
[
0
]
=
p
[
0
];
d
.
p
[
1
]
=
p
[
1
];
/* Clone child in new user namespace. */
pid
=
lxc_clone
(
run_userns_fn
,
&
d
,
CLONE_NEWUSER
);
if
(
pid
<
0
)
{
ERROR
(
"failed to clone child process in new user namespace"
);
goto
on_error
;
}
close
(
p
[
0
]);
p
[
0
]
=
-
1
;
euid
=
geteuid
();
egid
=
getegid
();
/* Allocate new {g,u}id map list. */
idmap
=
malloc
(
sizeof
(
*
idmap
));
if
(
!
idmap
)
goto
on_error
;
lxc_list_init
(
idmap
);
/* Find container root. */
lxc_list_for_each
(
cur
,
&
conf
->
id_map
)
{
struct
id_map
*
tmpmap
;
tmplist
=
malloc
(
sizeof
(
*
tmplist
));
if
(
!
tmplist
)
goto
on_error
;
tmpmap
=
malloc
(
sizeof
(
*
tmpmap
));
if
(
!
tmpmap
)
{
free
(
tmplist
);
goto
on_error
;
}
memset
(
tmpmap
,
0
,
sizeof
(
*
tmpmap
));
memcpy
(
tmpmap
,
cur
->
elem
,
sizeof
(
*
tmpmap
));
tmplist
->
elem
=
tmpmap
;
lxc_list_add_tail
(
idmap
,
tmplist
);
map
=
cur
->
elem
;
if
(
map
->
idtype
==
ID_TYPE_UID
)
if
(
euid
>=
map
->
hostid
&&
euid
<
map
->
hostid
+
map
->
range
)
host_uid_map
=
map
;
if
(
map
->
idtype
==
ID_TYPE_GID
)
if
(
egid
>=
map
->
hostid
&&
egid
<
map
->
hostid
+
map
->
range
)
host_gid_map
=
map
;
if
(
map
->
nsid
!=
0
)
continue
;
if
(
map
->
idtype
==
ID_TYPE_UID
)
if
(
container_root_uid
==
NULL
)
container_root_uid
=
map
;
if
(
map
->
idtype
==
ID_TYPE_GID
)
if
(
container_root_gid
==
NULL
)
container_root_gid
=
map
;
}
if
(
!
container_root_uid
||
!
container_root_gid
)
{
ERROR
(
"No mapping for container root found"
);
goto
on_error
;
}
/* Check whether the {g,u}id of the user has a mapping. */
if
(
!
host_uid_map
)
host_uid_map
=
idmap_add
(
conf
,
euid
,
ID_TYPE_UID
);
else
host_uid_map
=
container_root_uid
;
if
(
!
host_gid_map
)
host_gid_map
=
idmap_add
(
conf
,
egid
,
ID_TYPE_GID
);
else
host_gid_map
=
container_root_gid
;
if
(
!
host_uid_map
)
{
DEBUG
(
"Failed to find mapping for uid %d"
,
euid
);
goto
on_error
;
}
if
(
!
host_gid_map
)
{
DEBUG
(
"Failed to find mapping for gid %d"
,
egid
);
goto
on_error
;
}
if
(
host_uid_map
&&
(
host_uid_map
!=
container_root_uid
))
{
/* Add container root to the map. */
tmplist
=
malloc
(
sizeof
(
*
tmplist
));
if
(
!
tmplist
)
goto
on_error
;
lxc_list_add_elem
(
tmplist
,
host_uid_map
);
lxc_list_add_tail
(
idmap
,
tmplist
);
}
/* idmap will now keep track of that memory. */
host_uid_map
=
NULL
;
if
(
host_gid_map
&&
(
host_gid_map
!=
container_root_gid
))
{
tmplist
=
malloc
(
sizeof
(
*
tmplist
));
if
(
!
tmplist
)
goto
on_error
;
lxc_list_add_elem
(
tmplist
,
host_gid_map
);
lxc_list_add_tail
(
idmap
,
tmplist
);
}
/* idmap will now keep track of that memory. */
host_gid_map
=
NULL
;
if
(
lxc_log_get_level
()
==
LXC_LOG_LEVEL_TRACE
||
conf
->
loglevel
==
LXC_LOG_LEVEL_TRACE
)
{
lxc_list_for_each
(
cur
,
idmap
)
{
map
=
cur
->
elem
;
TRACE
(
"establishing %cid mapping for
\"
%d
\"
in new "
"user namespace: nsuid %lu - hostid %lu - range "
"%lu"
,
(
map
->
idtype
==
ID_TYPE_UID
)
?
'u'
:
'g'
,
pid
,
map
->
nsid
,
map
->
hostid
,
map
->
range
);
}
}
/* Set up {g,u}id mapping for user namespace of child process. */
ret
=
lxc_map_ids
(
idmap
,
pid
);
if
(
ret
<
0
)
{
ERROR
(
"error setting up {g,u}id mappings for child process "
"
\"
%d
\"
"
,
pid
);
goto
on_error
;
}
/* Tell child to proceed. */
if
(
write
(
p
[
1
],
&
c
,
1
)
!=
1
)
{
SYSERROR
(
"failed telling child process
\"
%d
\"
to proceed"
,
pid
);
goto
on_error
;
}
/* Wait for child to finish. */
ret
=
wait_for_pid
(
pid
);
on_error:
if
(
idmap
)
lxc_free_idmap
(
idmap
);
if
(
host_uid_map
&&
(
host_uid_map
!=
container_root_uid
))
free
(
host_uid_map
);
if
(
host_gid_map
&&
(
host_gid_map
!=
container_root_gid
))
free
(
host_gid_map
);
if
(
p
[
0
]
!=
-
1
)
close
(
p
[
0
]);
close
(
p
[
1
]);
return
ret
;
}
/* not thread-safe, do not use from api without first forking */
static
char
*
getuname
(
void
)
{
...
...
src/lxc/conf.h
View file @
dfb8c303
...
...
@@ -381,6 +381,8 @@ extern int chown_mapped_root(char *path, struct lxc_conf *conf);
extern
int
lxc_ttys_shift_ids
(
struct
lxc_conf
*
c
);
extern
int
userns_exec_1
(
struct
lxc_conf
*
conf
,
int
(
*
fn
)(
void
*
),
void
*
data
,
const
char
*
fn_name
);
extern
int
userns_exec_full
(
struct
lxc_conf
*
conf
,
int
(
*
fn
)(
void
*
),
void
*
data
,
const
char
*
fn_name
);
extern
int
parse_mntopts
(
const
char
*
mntopts
,
unsigned
long
*
mntflags
,
char
**
mntdata
);
extern
void
tmp_proc_unmount
(
struct
lxc_conf
*
lxc_conf
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment