storage: treat return value from ops->destroy as int

r->ops->destroy() returns an int, -1 on error. When assigned to a bool, this becomes true and hides errors. Signed-off-by: Michael McCracken <mikmccra@cisco.com>

storage: treat return value from ops->destroy as int
ed05aac8 · Michael McCracken · 7c76f495 · ed05aac8
Commit ed05aac8 authored Jan 19, 2018 by Michael McCracken
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

storage.c src/lxc/storage/storage.c +3 -2

No files found.
--- a/src/lxc/storage/storage.c
+++ b/src/lxc/storage/storage.c
@@ -603,13 +603,14 @@ bool storage_destroy(struct lxc_conf *conf)
 {
 	struct lxc_storage *r;
 	bool ret = false;
+	int destroy_rv = 0;

 	r = storage_init(conf);
 	if (!r)
 		return ret;

-	ret = r->ops->destroy(r);
-	if (ret == 0)
+	destroy_rv = r->ops->destroy(r);
+	if (destroy_rv == 0)
 		ret = true;

 	storage_put(r);