network.c:is_wlan() File Leak f

network.c:is_wlan() File Leak f f initialized at line 156 with fopen f leaks when fopen(path, r) != NULL at line 156 and physname == NULL at line 163. Signed-off-by: Wim Coekaerts <wim.coekaerts@oracle.com> Acked-by: Stéphane Graber <stgraber@ubuntu.com> Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>

network.c:is_wlan() File Leak f
ee54ea9a · Wim Coekaerts · Stéphane Graber · a90277df · ee54ea9a
Commit ee54ea9a authored Dec 28, 2015 by Wim Coekaerts Committed by Stéphane Graber Jan 04, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

network.c src/lxc/network.c +3 -1

No files found.
--- a/src/lxc/network.c
+++ b/src/lxc/network.c
@@ -158,8 +158,10 @@ static char * is_wlan(const char *ifname)
 	physlen = ftell(f);
 	fseek(f, 0, SEEK_SET);
 	physname = malloc(physlen+1);
-	if (!physname)
+	if (!physname) {
+		fclose(f);	
 		goto bad;
+	}
 	memset(physname, 0, physlen+1);
 	ret = fread(physname, 1, physlen, f);
 	fclose(f);