c/r: use snprintf to compute device name

This will never actually overflow, because %d is 32 bits and eth is 128 bytes long, but safety first :) Signed-off-by: Tycho Andersen <tycho.andersen@canonical.com>

c/r: use snprintf to compute device name
f28b1f68 · Tycho Andersen · Stéphane Graber · 4d411134 · f28b1f68
Commit f28b1f68 authored Oct 24, 2016 by Tycho Andersen Committed by Stéphane Graber Oct 26, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

criu.c src/lxc/criu.c +5 -2

No files found.
--- a/src/lxc/criu.c
+++ b/src/lxc/criu.c
@@ -443,8 +443,11 @@ static void exec_criu(struct criu_opts *opts)
 				if (strlen(n->name) >= sizeof(eth))
 					goto err;
 				strncpy(eth, n->name, sizeof(eth));
-			} else
-				sprintf(eth, "eth%d", netnr);
+			} else {
+				ret = snprintf(eth, sizeof(eth), "eth%d", netnr);
+				if (ret < 0 || ret >= sizeof(eth))
+					goto err;
+			}

 			switch (n->type) {
 			case LXC_NET_VETH: