Skip to content

L
lxc
Unverified Commit fc2ae783 by Christian Brauner Committed by Stéphane Graber
Options

utils: fix ppc64le builds

I suspect that there's a glibc bug on ppc64le. Both clang and gcc a very unhappy when you return -errno from these functions. Instead, let's return concrete errno numbers, e.g. -EINVAL. Signed-off-by: 's avatarChristian Brauner <christian.brauner@ubuntu.com>
parent c22b6119
Showing with 5 additions and 5 deletions
src/lxc/utils.c
......@@ -2008,7 +2008,7 @@ int lxc_safe_uint(const char *numstr, unsigned int *converted)
errno = 0;
uli = strtoul(numstr, &err, 0);
if (errno == ERANGE && uli == ULONG_MAX)
return -errno;
return -ERANGE;
if (err == numstr || *err != '\0')
return -EINVAL;
......@@ -2028,10 +2028,10 @@ int lxc_safe_int(const char *numstr, int *converted)
errno = 0;
sli = strtol(numstr, &err, 0);
if (errno == ERANGE && (sli == LONG_MAX || sli == LONG_MIN))
return -errno;
return -ERANGE;
if (errno != 0 && sli == 0)
return -errno;
return -EINVAL;
if (err == numstr || *err != '\0')
return -EINVAL;
......@@ -2051,10 +2051,10 @@ int lxc_safe_long(const char *numstr, long int *converted)
errno = 0;
sli = strtol(numstr, &err, 0);
if (errno == ERANGE && (sli == LONG_MAX || sli == LONG_MIN))
return -errno;
return -ERANGE;
if (errno != 0 && sli == 0)
return -errno;
return -EINVAL;
if (err == numstr || *err != '\0')
return -EINVAL;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment