Skip to content

L
lxc
Unverified Commit fddd112c by Tobin C. Harding Committed by Christian Brauner
Options

cmd: Do not reassign variable before it is used

cppcheck emits warning Variable 'ofd' is reassigned a value before the old one has been used. We do not need to initialise a variable if it is assigned to on first use. Signed-off-by: 's avatarTobin C. Harding <me@tobin.cc>
parent 349df8e3
Showing with 3 additions and 4 deletions
src/lxc/cmd/lxc_user_nic.c
...@@ -862,12 +862,12 @@ again: ...@@ -862,12 +862,12 @@ again:
static char *lxc_secure_rename_in_ns(int pid, char *oldname, char *newname, static char *lxc_secure_rename_in_ns(int pid, char *oldname, char *newname,
int *container_veth_ifidx) int *container_veth_ifidx)
{ {
int ret; int ofd, ret;
pid_t pid_self; pid_t pid_self;
uid_t ruid, suid, euid; uid_t ruid, suid, euid;
char ifname[IFNAMSIZ]; char ifname[IFNAMSIZ];
char *string_ret = NULL, *name = NULL; char *string_ret = NULL, *name = NULL;
int fd = -1, ifindex = -1, ofd = -1; int fd = -1, ifindex = -1;
pid_self = lxc_raw_getpid(); pid_self = lxc_raw_getpid();
...@@ -1035,11 +1035,10 @@ struct user_nic_args { ...@@ -1035,11 +1035,10 @@ struct user_nic_args {
static bool is_privileged_over_netns(int netns_fd) static bool is_privileged_over_netns(int netns_fd)
{ {
int ret; int ofd, ret;
pid_t pid_self; pid_t pid_self;
uid_t euid, ruid, suid; uid_t euid, ruid, suid;
bool bret = false; bool bret = false;
int ofd = -1;
pid_self = lxc_raw_getpid(); pid_self = lxc_raw_getpid();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment