Commits · 069e60e4d8c914ccb5461ef0e84bbf8563ee52fd · Chen Yisong / lxc

17 Dec, 2017 40 commits

authored Nov 22, 2017

This checks whether multiple concurrent waiters all get notified by the state
server.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

069e60e4

commands: allow waiting for all states · fc11025a
Christian Brauner authored Nov 21, 2017
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
fc11025a

start: don't lock setting the state · f984925d

authored Nov 22, 2017

- setting the handler->state value is atomic on any POSIX implementation since
  we're dealing with an integer (enum/lxc_state_t)
- while the state clients are served it is not possible for lxc_set_state() to
  transition to the next state anyway so there's no danger in moving to the
  next state with clients missing it
- we only care about the list being modified
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

f984925d

commands: don't lock the whole command · 805573c4

authored Nov 22, 2017

There are multiple reasons why this is not required:
- every command is transactional
- we only care about the list being modified not the memory allocation and
  other costly operations
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

805573c4

commands: don't lock atomic operations · ce3a1c7b

authored Nov 22, 2017

We're dealing with an integer (lxc_state_t which is an enum). Any POSIX
implementation makes those operations atomic so there's not need in locking
this.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

ce3a1c7b

commands: don't traverse whole list · aa4401ae

authored Nov 22, 2017

When we remove a state client fd there's not reason to walk the whole list. We
can simply break once we found and removed the fd.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

aa4401ae

start: set loglevel correctly · 91e46cb1

authored Dec 06, 2017

We want the loglevel that the user specified when starting the container
because it overrides the default one set in the config.

Closes #2003.
Reported-by: Felix Abecassis <fabecassis@nvidia.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

91e46cb1

arguments: move to tools/ subdirectory · 8bedc7ee

authored Dec 04, 2017

The arguments.{c,h} file should not be a part of liblxc itself. It should only
be used for the lxc tools.
Signed-off-by: RicardoSanchezA <ricardo.sanchez@utexas.edu>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

8bedc7ee

lxc_execute: properly figure out number of needed arguments · ec4f7bc7

authored Dec 04, 2017

The lxc_log args have noghing to do with lxc.rootfs.path, and
we need room for a NULL at end of arguments.

How this bug was hidden for so long I don't know - I can only
trigger it on certain systems under certain conditions, but it's
definately wrong as is.
Signed-off-by: Serge Hallyn <shallyn@cisco.com>

ec4f7bc7

test: reenable Coverity integration · 32ee5a51
Christian Brauner authored Dec 04, 2017
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
32ee5a51
attach: do not fail on non-existing namespaces · 4feff04a
Christian Brauner authored Dec 04, 2017
```
Closes #1993.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
4feff04a
criu: silence static analysis · fbced262
Christian Brauner authored Dec 04, 2017
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
fbced262
confile: remove dead assignment · 239f3f78
Christian Brauner authored Dec 04, 2017
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
239f3f78
criu: initialize status · 36074755
Christian Brauner authored Dec 04, 2017
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
36074755
conf: prevent null pointer dereference · a46188c6
Christian Brauner authored Dec 04, 2017
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
a46188c6
Insert missing "echo" after "is_enabled" · e577ba6b
Pierre LALET authored Dec 03, 2017
```
Signed-off-by: Pierre LALET <pierre.lalet@cea.fr>
```
e577ba6b
Fix SETCOLOR_FAILURE evaluation · ba041b30
Pierre LALET authored Dec 03, 2017
```
Signed-off-by: Pierre LALET <pierre.lalet@cea.fr>
```
ba041b30

Add bash completion to list backing store types for lxc-create -B · 0f71d53c

authored Dec 03, 2017

- Backing Store types are hard-coded (Not sure how to get programmatically)
- Closes #1236
Signed-off-by: Abbas Ally <abbasally5@yahoo.com>

0f71d53c

Add new dependency to Slackware template · 71c0b35b

authored Dec 02, 2017

I followed the [changelog of Slackware-current]<http://www.slackware.com/changelog/>,
and found that Slackware-current split hostname utility from util-linux package in Nov 17 2017.
So I add the new package to the template.
Signed-off-by: Chia-Chun Hsu <a12321aabb@gmail.com>

71c0b35b

Update gentoo.moresecure.conf. · aad14f73

authored Dec 02, 2017

Closes https://github.com/lxc/lxc/issues/1928Signed-off-by: i.Dark_Templar <darktemplar@dark-templar-archives.net>

aad14f73

lxc_unshare: Add uid_mapping when creating userns · 0dd8fb29

authored Nov 28, 2017

Change conf.c to export function write_id_mapping, which will now be
called inside main function of lxc_unshare.c.

This is required because setuid syscalls only permits a new userns to
set a new uid if the uid of parameter is mapped inside the ns using
uid_map file[1]. So, just after the clone invocation, map the uid passed as
parameter into the newly created user namespace, and put the current uid
as the ID-outside-ns. After the mapping is done, setuid call succeeds.

Closes: #494

[1] https://elixir.free-electrons.com/linux/latest/source/kernel/user_namespace.c#L286Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>

0dd8fb29

utils: declare sethostname() static inline · 3fb37977
Christian Brauner authored Dec 01, 2017
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
3fb37977
confile: fix memory leak · c0979ab7
Felix Abecassis authored Nov 28, 2017
```
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
```
c0979ab7
tools/lxc_wait: removed internal logging · 405f0aec
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
405f0aec
tools/lxc_usernsexec: removed internal logging · fb697f2f
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
fb697f2f
tools/lxc_unshare: removed internal logging · b55e5e31
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
b55e5e31
tools/lxc_unfreeze: removed internal logging · 50ea49c4
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
50ea49c4
tools/lxc_top: removed internal logging · 534a6aaf
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
534a6aaf
tools/lxc_stop: removed internal logging · 0571062f
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
0571062f
tools/lxc_start: removed internal logging · e96df99b
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
e96df99b
tools/lxc_snapshot: removed internal logging · a9da03a7
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
a9da03a7
tools/lxc_monitor: removed internal logging · 3dba1ad7
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
3dba1ad7
tools/lxc_copy: remove internal logging · 62aebd99
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
62aebd99
tools/lxc_ls: remove internal logging · 2a82ac7c
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
2a82ac7c

storage: remove unused declaration · 6dc83f4e

authored Nov 28, 2017

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Adrian Reber <areber@redhat.com>

6dc83f4e

lxccontainer: various container creation fixes · 0e5eb43a

authored Nov 28, 2017

This is beneficial for LXD as well.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Adrian Reber <areber@redhat.com>

0e5eb43a

criu: detect veth name · 84c29b84

authored Nov 27, 2017

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Adrian Reber <areber@redhat.com>

84c29b84

tools/lxc_info: removed internal logging · b1ba7b0f
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
b1ba7b0f
tools/lxc_freeze: remove internal logging · 18322934
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
18322934
tools/lxc_execute: removed internal logging · 8ab75ebe
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
8ab75ebe