- 12 Nov, 2013 6 commits
-
-
KATOH Yasufumi authored
Update for commit b9d957c3Signed-off-by:
KATOH Yasufumi <karma@jazz.email.ne.jp> Acked-by:
Stéphane Graber <stgraber@ubuntu.com>
-
KATOH Yasufumi authored
Update for commit 2752ececSigned-off-by:
-
pc-wurm authored
I think '-t timeout' was mistakenly written, so I corrected it to '-t template', since the -t argument is used for setting templates, not timeout as far as I know. Signed-off-by:
pc-wurm <yordanov@pc-wurm.de> Acked-by:
-
Stéphane Graber authored
Signed-off-by:
Serge Hallyn <serge.hallyn@ubuntu.com>
-
Dwight Engen authored
This is likely unnecessary, but is consistent with other uses of fopen()/fclose() in lxc. Signed-off-by:
Dwight Engen <dwight.engen@oracle.com> Acked-by:
S.Çağlar Onur <caglar@10ur.org> Signed-off-by:
-
Dwight Engen authored
We were calling save_config() twice within the create() flow, each from a different process. Depending on order of scheduling, sometimes the data from the first save_config() (which was just the stuff from LXC_DEFAULT_CONFIG) would overwrite the config we wanted (the full config), causing a truncated config file which would then cause lxc to segfault once it read it back in because no rootfs.path was set. This fixes it by only calling save_config() once in the create() flow. A rejected alternative was to call fsync(fileno(fout)) before the fclose in save_config. Signed-off-by:
-
- 11 Nov, 2013 1 commit
-
-
Serge Hallyn authored
commit aae93dd3 fixed the command socket name to use the right pathlen instead of always passing in the max socket namelen. However, this breaks lxc-info/lxc-list/etc for containers started before that commit. So if the correct command sock name doesn't work, try the preexising one. Note we can probably undo this "after awhile". Maybe in august 2014. Signed-off-by:
-
- 08 Nov, 2013 4 commits
-
-
Dwight Engen authored
- This allows testing independently the modes with/without threading Signed-off-by:
-
Serge Hallyn authored
Otherwise we can reap another thread's forked pid. Changelog: Per Dwight's suggestion, use pid_t for argument. Signed-off-by:
-
Serge Hallyn authored
lxc-start is not safe (and doesn't actually make sense) if the task is nto single-threaded. Signed-off-by:
-
Qiang Huang authored
It's a duplicate of util.h. Signed-off-by:
Qiang Huang <h.huangqiang@huawei.com> Signed-off-by:
-
- 06 Nov, 2013 8 commits
-
-
Dwight Engen authored
I accidentally introduced this with the change to lxc-info (commit b9d957c3). Signed-off-by:
-
Serge Hallyn authored
To do so we do a quick setns into the container's netns. This (unexpectedly) turns out cleaner than trying to rename it from lxc_setup(), because we don't know the original nic name in the container until we created it which we do in the parent after the init has been cloned. Signed-off-by:
-
Serge Hallyn authored
conf.c/conf.h: have replaced bool hostid_is_mapped() with int mapped_hostid() which returns the mapped uid for the caller's uid on the host, or -1 if none create_run_template: pass caller's uid into template. lxc-ubuntu-cloud: 1. accept --mapped-uid argument 2. don't write to devices cgroup - not allowed. 3. if running in userns, use $HOME/.cache 4. chown cached files to the uid to which our caller was mapped 5. ignore /dev when extracting rootfs in a userns Changelog: nov 5: remove debugging INFO line. Signed-off-by:
-
Dwight Engen authored
- allow lxc-info to show more than one container, using regex for the name Signed-off-by:
-
Dwight Engen authored
Found by running the lxc-test-list test with valgrind. The names were put into a local array, and never freed in the success case where the caller didn't want the names returned and in the early out failure case. Note we don't need to check the return from remove_from_array() because we just successfully added the name above. Signed-off-by:
-
Dwight Engen authored
Signed-off-by:
-
Dwight Engen authored
Changelog: [serge] remove unneeded explicity qsort call Signed-off-by:
-
Stéphane Graber authored
Signed-off-by:
-
- 05 Nov, 2013 4 commits
-
-
Stéphane Graber authored
Signed-off-by: -
Dwight Engen authored
Signed-off-by:
-
Dwight Engen authored
Signed-off-by:
-
Dwight Engen authored
Containers started with lxc-execute may not have a conf, but nothing in the implementation of lxcapi_get_cgroup_item() actually needs/uses it, and it can be useful to get items out of the containers' cgroup items. Signed-off-by:
-
- 04 Nov, 2013 5 commits
-
-
Dwight Engen authored
- Also removed duplicate stats_clear lua function Signed-off-by:
-
Dwight Engen authored
Previously, the lua stats collection was building its own paths to the cgroup files, which could be wrong depending on what --with-cgroup-pattern was passed to configure. Fix it to use the get_cgroup_item api so it always finds the files. Remove cgroup_path_get since it is not used anymore. Signed-off-by:
-
Dwight Engen authored
fix up api test to run and add test for new [gs]et_cgroup_item Signed-off-by:
-
S.Çağlar Onur authored
Signed-off-by:
-
S.Çağlar Onur authored
Signed-off-by:
-
- 01 Nov, 2013 4 commits
-
-
S.Çağlar Onur authored
Signed-off-by:
-
S.Çağlar Onur authored
valgrind drd tool shows conflicting stores happening at lxc_global_config_value@src/lxc/utils.c (v2) Conflict occurs between following lines [...] 269 if (values[i]) 270 return values[i]; [...] and [...] 309 /* could not find value, use default */ 310 values[i] = (*ptr)[1]; [...] fix it using a specific lock dedicated to that problem as Serge suggested. Also introduce a new autoconf parameter (--enable-mutex-debugging) to convert mutexes to error reporting type and to provide a stacktrace when locking fails. Signed-off-by:
-
Serge Hallyn authored
If we're not root, our mounts in private userns won't get pushed back anyway. If we are root, we need to make sure that anything the template does gets cleaned up. Signed-off-by:
-
Serge Hallyn authored
They are a nuisance. Signed-off-by:
-
- 30 Oct, 2013 8 commits
-
-
Dwight Engen authored
I goofed and left in a getchar() that I was using to pause the test program in a case that was failing for me. Remove it. Signed-off-by:
-
S.Çağlar Onur authored
daemonize implies close_all_fds so set it in lxcapi_want_daemonize instead of setting in every cli or in every binding explicitly Reported-by:
Fatih Arslan <ftharsln@gmail.com> Signed-off-by:
-
Serge Hallyn authored
lxc_conf exists after api_save_config Signed-off-by: -
Serge Hallyn authored
don't use lxcpath variable for rootfs_path, it's confusing. if rootfs is passed in and tpath is passed in, return error before we save a new config, and don't delete the container make sure to check c->lxc_conf is not NULL before dereferencing it. Signed-off-by: -
Sheng Yong authored
1. rootfs.path set, -t not set: rootfs.path is rootfs path 2. rootfs.path set, -t set: change template default path to rootfs path 3. rootfs.path not set, -t set: template default path is rootfs path 4. rootfs.path not set, -t not set: error 5. rootfs.path set but cannot access: error Signed-off-by:
Sheng Yong <shyodx@gmail.com> Signed-off-by:
-
Sheng Yong authored
If lxc.rootfs is specified, we believe rootfs is ready. lxc-start will check this later. Return true, because the container is created. Signed-off-by:
-
Dwight Engen authored
Signed-off-by:
-
Dwight Engen authored
Commit 1ea59ad2 sets memory.use_hierarchy, which means that this test cannot use memory.swappiness as its dummy cgroup item to set/unset since writing to it with use_hierarchy set gets -EINVAL. Change test to use memory.soft_limit_in_bytes instead. Signed-off-by:
-
