Commits · 3975ef41d2ef2d8236b7f36ac670b5d2dcf60d0f · Chen Yisong / lxc · GitLab

26 Feb, 2021 40 commits
- commands: add LXC_CMD_GET_CGROUP_FD and LXC_CMD_GET_LIMIT_CGROUP_FD · 3975ef41
  Christian Brauner authored Feb 24, 2021
```
and port cgroup_get() and cgroup_set(). This means no more useless cgroup
driver initialization on ever get or set.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  3975ef41
- commands: extend rsp_one_fd() to also handle additional data · 5d8caeb9
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  5d8caeb9
- file_utils: actually open the file for reading · 236f4175
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  236f4175
- commands: set rsp.ret to 0 for lxc_cmd_get_cgroup_ctx_callback() · 9bfcfda5
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  9bfcfda5
- cgroups: s/cgroup_layout/layout/g · 7c16820e
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  7c16820e
- commands: add LXC_CMD_GET_CGROUP_FD and LXC_CMD_GET_LIMIT_CGROUP_FD · d5d3ed27
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  d5d3ed27
- commands: s/_LIMITING_/_LIMIT_/g and s/_limiting_/_limit_/g · cfd0e3b5
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  cfd0e3b5
- commands: simplify lxc_cmd_get_cgroup_ctx() · dd65d42a
  Christian Brauner authored Feb 24, 2021
```
Instead of allowing individual hierarchy fd retrieval through
lxc_cmd_get_cgroup_ctx() let's add a dedicated method instead.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  dd65d42a
- commands: fix alignment for lxc_cmd_get_cgroup_ctx() · a4e04834
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  a4e04834
- cgroups: handle fallback gracefully · 292f9985
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  292f9985
- cgroups: make use of ERRNO_IS_NOT_SUPPORTED() · 1274eb5c
  Christian Brauner authored Feb 24, 2021
```
This will hopefully prevent backwards compatibility fallback errors.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  1274eb5c
- error_utils: copy over Lennart's IN_SET() · 0e48c43b
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  0e48c43b
- commands: tweak return values · 870a288c
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  870a288c
- error_utils: move error helper to separate header · f3aca94f
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  f3aca94f
- cgroups: simple variable reordering · 976faade
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  976faade
- attach: be paranoid about file descriptors · f7103f3b
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  f7103f3b
- cgroups: fix braino during controller list creation · 2fe672bb
  Christian Brauner authored Feb 24, 2021
```
Co-mounted controllers are conventionally separated by ",".

Fixes: https://jenkins.linuxcontainers.org/job/lxd-github-commit/1905/arch=amd64,backend=dir,compiler=golang-1.15/consoleFullSigned-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  2fe672bb
- commands: remove faulty use of access attribute · 56cf060c
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  56cf060c
- cgroups: fix error checking · a23ad648
  Christian Brauner authored Feb 23, 2021
```
Fixes: Coverity 1473310
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  a23ad648
- af_unix: prevent oob writes · 82ba06f6
  Christian Brauner authored Feb 23, 2021
```
Fixes: Coverity 1473309
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  82ba06f6
- commands: only deref once · 90b9b14c
  Christian Brauner authored Feb 23, 2021
```
Fixes: Coverity 1473308
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  90b9b14c
- commands: handle old clients for LXC_CMD_GET_CGROUP_CTX · 8a173162
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  8a173162
- attach: handle new and old clients · 490265b1
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  490265b1
- attach: make fd sending more uniform · ce35e244
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  ce35e244
- terminal: dumb logging down · 80f07b8b
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  80f07b8b
- attach: fix namespace preservation · 2c8089b4
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  2c8089b4
- commands: verify expected file descriptors were sent · aeadb8f5
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  aeadb8f5
- commands: handle older clients gracefully · cdc2c871
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  cdc2c871
- attach: remove additional newline · abe00764
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  abe00764
- af_unix: add comment about cast · e5acb39d
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  e5acb39d
- attach: fix unsupported namespaces · c6062fcd
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  c6062fcd
- commands: lxc_cmd_add_state_client_callback() · 87834acf
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  87834acf
- commands: handle older clients elegantly · d8c81a7c
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  d8c81a7c
- commands: send ENOSYS response · d1110354
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  d1110354
- cgroups: introduce fd-only cgroup attach · e040efb6
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  e040efb6
- commands: introduce LXC_CMD_GET_CGROUP_CTX · b106d22f
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  b106d22f
- utils: add copy_struct_to_client() · 89b2bfaa
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  89b2bfaa
- log: add syswarn_set() · aa659ba5
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  aa659ba5
- utils: add copy_struct_from_client() · 40f99fdc
  Christian Brauner authored Feb 23, 2021
```
Which is our variant of copy_struct_from_user() that Aleksa and I added to the
kernel.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  40f99fdc
- macro: add min() macro · 8302a79b
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  8302a79b