Signed-off-by: tomponline <tomp@tomp.uk>

Signed-off-by: tomponline <tomp@tomp.uk>

Signed-off-by: tomponline <tomp@tomp.uk>

hardening: enable address sanitizer build

This adds --{disable,enable}-asan. It is disabled by default.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Fix PID namespace pdeathsig handling

Fixes: #2902
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>

Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>

compiler: hardening

This hardens multi-threaded C. Without it, the implementation of thread
cancellation handlers (introduced by pthread_cleanup_push) uses a completely
unprotected function pointer on the stack. This function pointer can simplify
the exploitation of stack-based buffer overflows even if the thread in question
is never canceled.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Avoid temporary files, speeding up builds.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Increased reliability of backtraces.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

btrfs: ensure \0 byte at end

Apparently the name received from the tree walk is not guaranteed to have \0
byte at the end. So let's make sure we append one.
Note that this is only an issue if there are any subvolumes in the container's
rootfs.

Closes 2826.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

hooks: drop namespace references before post-stop

Callers such as LXD run post-stop hooks to perform cleanup operations on
shutdown. This can involve umount and other things. To avoid surprises with
lingering namespace references we should close all our namespace-preserving
file descriptors. We don't need them at this point anymore anyway.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Fix lxc.cgroup2.<controller> on cgroup2-only systems

Signed-off-by: Michael Sparmann <theseven@gmx.net>

conf: avoid compiler warning

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

This reverts commit 912c4bb4.

I accidently merged this commit. The initialization is wrong.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: Fixes uninitialised variable.

> @brauner clang is failing but gcc passes, would it be OK to initialise this to 0?

He, unfortunately not. :)
What would happen now is that you'd close `stdin` on a standard system. What you'd want is `= -EBADF`. :)

Signed-off-by: tomponline <tomp@tomp.uk>

minor tweaks

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: fix wrong licensing

tree-wide: kill fgets()

gcc -Wall flag compat

Closes #2885.
Signed-off-by: tomponline <tomp@tomp.uk>

Closes #2885.
Signed-off-by: tomponline <tomp@tomp.uk>

Closes #2885.
Signed-off-by: tomponline <tomp@tomp.uk>

Closes #2885.
Signed-off-by: tomponline <tomp@tomp.uk>

Closes #2885.
Signed-off-by: tomponline <tomp@tomp.uk>

Closes #2885.
Signed-off-by: tomponline <tomp@tomp.uk>

Signed-off-by: tomponline <tomp@tomp.uk>

Signed-off-by: tomponline <tomp@tomp.uk>

Invalid warning but let's please the compiler.

Closes lxc#2885.
Signed-off-by: tomponline <tomp@tomp.uk>

Closes lxc#2885.
Signed-off-by: tomponline <tomp@tomp.uk>