Commits · 4cd72b693cc0c9f5d37464eb27844dfdd1ddf9ad · Chen Yisong / lxc

10 Apr, 2021 1 commit

tests: fix a memory leak in lxcpath · 4cd72b69

authored Apr 10, 2021

```
$ sudo ./src/tests/lxc-test-lxcpath

=================================================================
==95911==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 39 byte(s) in 1 object(s) allocated from:
    #0 0x7effafc8d3dd in strdup (/lib/x86_64-linux-gnu/libasan.so.5+0x963dd)
    #1 0x7effaf5a2de6 in lxcapi_config_file_name /home/vagrant/lxc/src/lxc/lxccontainer.c:3190
    #2 0x562961680c30 in main /home/vagrant/lxc/src/tests/lxcpath.c:49
    #3 0x7effae5150b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

Direct leak of 21 byte(s) in 1 object(s) allocated from:
    #0 0x7effafc8d3dd in strdup (/lib/x86_64-linux-gnu/libasan.so.5+0x963dd)
    #1 0x7effaf5a2de6 in lxcapi_config_file_name /home/vagrant/lxc/src/lxc/lxccontainer.c:3190
    #2 0x56296168115e in main /home/vagrant/lxc/src/tests/lxcpath.c:77
    #3 0x7effae5150b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

Direct leak of 21 byte(s) in 1 object(s) allocated from:
    #0 0x7effafc8d3dd in strdup (/lib/x86_64-linux-gnu/libasan.so.5+0x963dd)
    #1 0x7effaf5a2de6 in lxcapi_config_file_name /home/vagrant/lxc/src/lxc/lxccontainer.c:3190
    #2 0x562961680f0a in main /home/vagrant/lxc/src/tests/lxcpath.c:63
    #3 0x7effae5150b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

SUMMARY: AddressSanitizer: 81 byte(s) leaked in 3 allocation(s).
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>

4cd72b69

12 Apr, 2021 6 commits
- Merge pull request #3779 from brauner/2021-04-12/attach_fixes · aeff7df6
  Stéphane Graber authored Apr 12, 2021
```
attach: fixes
```
  aeff7df6
- Revert "rexec: mark all fds as close-on-exec if possible" · 09a83db5
  Christian Brauner authored Apr 12, 2021
```
This reverts commit 531d36ad.

Callers might want to explicilty inhert file descriptors so we can't
close them behind their back when we exec.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  09a83db5
- attach: don't return early when calculating namespaces via pidfd · 0b8e876f
  Christian Brauner authored Apr 12, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  0b8e876f
- Merge pull request #3778 from brauner/2021-04-12/fixes · d32dcd01
  Stéphane Graber authored Apr 12, 2021
```
conf: idmaptool fixes
```
  d32dcd01
- conf: don't report success when idmaptools lack all privilege · a864a2e1
  Christian Brauner authored Apr 12, 2021
```
Fixes: #3777
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  a864a2e1
- conf: simplify idmaptool_on_path_and_privileged() · 83cb7362
  Christian Brauner authored Apr 12, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  83cb7362
07 Apr, 2021 9 commits
- Merge pull request #3775 from brauner/2021-04-07/fixes · 965502a0
  Stéphane Graber authored Apr 07, 2021
```
confile: make lxc_get_config() and lxc_get_config_net() always return…
```
  965502a0
- confile: make lxc_get_config() and lxc_get_config_net() always return non-NULL · 6773e108
  Christian Brauner authored Apr 07, 2021
```
Introduce the concept of an unsupported config item.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  6773e108
- Merge pull request #3774 from stgraber/master · 33c0a546
  Christian Brauner authored Apr 07, 2021
```
github: Try to fix action naming
```
  33c0a546
- github: Try to fix action naming · 7e8b9b04
  Stéphane Graber authored Apr 07, 2021
```
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
```
  7e8b9b04
- Merge pull request #3773 from brauner/2021-04-06/fixes_2 · f0c6219a
  Stéphane Graber authored Apr 07, 2021
```
confile & log: fixes
```
  f0c6219a
- confile: enforce maximum subkey length · ae393e13
  Christian Brauner authored Apr 06, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  ae393e13
- log: add error_ret() · c3cef319
  Christian Brauner authored Apr 06, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  c3cef319
- macro: ensure ret_errno() always returns negative · 0a3b86f9
  Christian Brauner authored Apr 06, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  0a3b86f9
- Merge pull request #3763 from evverx/fuzz-lxc-define-load · 9d984c3f
  Christian Brauner authored Apr 07, 2021
```
oss-fuzz: fuzz lxc_config_define_add and lxc_config_define_load
```
  9d984c3f
06 Apr, 2021 5 commits

Merge pull request #3772 from merlin1991/master · ace51ce8
Stéphane Graber authored Apr 06, 2021
```
templates/*.in: fixed PATH handling with spaces
```
ace51ce8

templates/*.in: fixed PATH handling with spaces · 655d10ed

authored Apr 06, 2021

if $PATH already contains a path with a space the append of the
default directories in all template scripts fails with an error
like the following:

/usr/share/lxc/templates/lxc-download: 69: export: (x86)/NVIDIA: bad
variable name
Signed-off-by: Christian Ratzenhofer <christian.ratzenhofer@cdnm.at>

655d10ed

Merge pull request #3771 from brauner/2021-04-06/fixes · 093bfcc8
Stéphane Graber authored Apr 06, 2021
```
conf: fix setups where /dev is outside of LXC's control
```
093bfcc8
log: ensure we always return negative errno · e2c8dbd8
Christian Brauner authored Apr 06, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
e2c8dbd8

conf: fix setups where /dev is outside of LXC's control · 1f0a3b6e

authored Apr 06, 2021

Fixes: #3770
Suggested-by: Ruben Jenster <r.jenster@drachenfels.de>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

1f0a3b6e

02 Apr, 2021 5 commits
- Merge pull request #3766 from brauner/2021-04-02/fixes_2 · d75ddd9b
  Stéphane Graber authored Apr 02, 2021
```
lsm: fixes
```
  d75ddd9b
- confile: complain when LXC is built without AppArmor support · 8f899a4a
  Christian Brauner authored Apr 02, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  8f899a4a
- confile: complain when LXC is built without selinux support · d6df2b8f
  Christian Brauner authored Apr 02, 2021
```
Link: https://github.com/lxc/lxc/issues/3765Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  d6df2b8f
- Merge pull request #3764 from brauner/2021-04-02/fixes · 6fde9fb1
  Stéphane Graber authored Apr 02, 2021
```
confile: fix lxc.namespace.share.[identifier]
```
  6fde9fb1
- confile: fix lxc.namespace.share.[identifier] · 057d2cae
  Christian Brauner authored Apr 02, 2021
```
Link: https://github.com/lxc/lxc/pull/3763/files#r606089660Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  057d2cae
01 Apr, 2021 11 commits

Merge pull request #3762 from brauner/2021-03-31/fixes · 8aa60255
Stéphane Graber authored Apr 01, 2021
```
fixes: Makefile, lxc-user-nic, simplify get_network_config_ops()
```
8aa60255
confile: simplify get_network_config_ops() · 7707b0e0
Christian Brauner authored Apr 01, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
7707b0e0
string_utils: use restrict for lxc_safe_int64_residual() · 59f5a103
Christian Brauner authored Apr 01, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
59f5a103
string_utils: ensure that errno is set on return · 90e69d71
Christian Brauner authored Apr 01, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
90e69d71

string_utils: move to lxc-copy() sources · 5fba37a1

authored Apr 01, 2021

It's the only place where it is still used.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

5fba37a1

lxc_user_nic: cleanup get_alloted() · 68dd0ea5
Christian Brauner authored Mar 31, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
68dd0ea5
lxc_user_nic: cleanup append_alloted() · 4c7de7c5
Christian Brauner authored Mar 31, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
4c7de7c5
Merge pull request #3760 from evverx/reject-giant-configs · b405dec6
Christian Brauner authored Apr 01, 2021
```
oss-fuzz: reject giant configs early
```
b405dec6
cifuzz: fuzz longer · 55376ebd
Evgeny Vereshchagin authored Mar 31, 2021
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
55376ebd

confile: fix a memory leak lxc_config_define_add · 1a46f853

authored Mar 31, 2021

```
2021-04-02T05:45:54.9410345Z ==13==ERROR: LeakSanitizer: detected memory leaks
2021-04-02T05:45:54.9410737Z
2021-04-02T05:45:54.9411488Z Direct leak of 16 byte(s) in 1 object(s) allocated from:
2021-04-02T05:45:54.9412556Z     #0 0x54d752 in calloc /src/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:154:3
2021-04-02T05:45:54.9413360Z     #1 0x583795 in parse_new_conf_line /src/lxc/src/lxc/confile.c:3048:8
2021-04-02T05:45:54.9414057Z     #2 0x582f1a in lxc_config_define_add /src/lxc/src/lxc/confile.c:3090:15
2021-04-02T05:45:54.9415352Z     #3 0x5810fa in LLVMFuzzerTestOneInput /src/lxc/src/tests/fuzz-lxc-define-load.c:30:6
2021-04-02T05:45:54.9419212Z     #4 0x483b93 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:599:15
2021-04-02T05:45:54.9421819Z     #5 0x48309a in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool, bool*) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:505:3
2021-04-02T05:45:54.9424205Z     #6 0x485474 in fuzzer::Fuzzer::ReadAndExecuteSeedCorpora(std::__Fuzzer::vector<fuzzer::SizedFile, fuzzer::fuzzer_allocator<fuzzer::SizedFile> >&) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:814:7
2021-04-02T05:45:54.9426658Z     #7 0x485689 in fuzzer::Fuzzer::Loop(std::__Fuzzer::vector<fuzzer::SizedFile, fuzzer::fuzzer_allocator<fuzzer::SizedFile> >&) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:845:3
2021-04-02T05:45:54.9428616Z     #8 0x473717 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:906:6
2021-04-02T05:45:54.9429989Z     #9 0x49f572 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
2021-04-02T05:45:54.9433312Z     #10 0x7fa96041b83f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2083f)
2021-04-02T05:45:54.9433795Z
2021-04-02T05:45:54.9434661Z DEDUP_TOKEN: calloc--parse_new_conf_line--lxc_config_define_add
2021-04-02T05:45:54.9435483Z SUMMARY: AddressSanitizer: 16 byte(s) leaked in 1 allocation(s).
2021-04-02T05:45:54.9435958Z
2021-04-02T05:45:54.9436404Z INFO: a leak has been found in the initial corpus.
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>

1a46f853

oss-fuzz: fuzz lxc_config_define_add and lxc_config_define_load · e8694d9a
Evgeny Vereshchagin authored Mar 31, 2021
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
e8694d9a

31 Mar, 2021 3 commits
- Merge pull request #3759 from evverx/san-compatible · f5312e35
  Christian Brauner authored Mar 31, 2021
```
build-system: make it compatible with ASan/UBsan/Msan
```
  f5312e35
- Merge pull request #3758 from brauner/2021-03-31/fixes · 6dcd23e2
  Stéphane Graber authored Mar 31, 2021
```
confile: cap to last bit in set_config_net_ipv4_address()
```
  6dcd23e2
- confile: cap to last bit in set_config_net_ipv4_address() · 36513635
  Christian Brauner authored Mar 31, 2021
```
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32708Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  36513635