Commits · 4e771848a67ab00279538457deda8e8e6d4be2bd · Chen Yisong / lxc · GitLab

26 Feb, 2021 40 commits
- utils: fix print_r() debugging helper · 4e771848
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  4e771848
- cgroups: fix error values · 5bd52b01
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  5bd52b01
- cgroups: don't overwrite type · 3bb6756d
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  3bb6756d
- cgroups: make it extremely obvious that we're transitioning from a flag to a type · b9a9768c
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  b9a9768c
- cgroups: create controller directories if missing · 6194bad7
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  6194bad7
- cgroups: use non-flag based checking now that we switched all codepaths over · 4ab1d9a6
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  4ab1d9a6
- conf: use brackets to clarify check semantics · 0679efa0
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  0679efa0
- cgroups: validate that only a single cgroup mount type is set · 16ed8086
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  16ed8086
- cgroups: prevent cgroup mount type overwrite · d6614b80
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  d6614b80
- cgroups: ensure that cgroup_root is initialized in legacy codepaths · 3a72de50
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  3a72de50
- cgroups: distinguish between tmpfs and unified based cgroup layouts file descriptors · b7967f52
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  b7967f52
- cgroups: log intermediate cleanup · 0bdd81d9
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  0bdd81d9
- cgroups: prevent NULL pointer deref · 2e5d1172
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  2e5d1172
- cgroups: simplify mount opening · c46e18f5
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  c46e18f5
- cgroups: ensure we prune the limit dir · 192711f0
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  192711f0
- cgroups: ensure we don't remove cgroups we didn't create · 1a9fab99
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  1a9fab99
- cgroups: don't move pivot cgroup under the monitor's cgroup · 699919e6
  Christian Brauner authored Feb 17, 2021
```
Otherwise we will never be able to destroy the monitor's cgroup.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  699919e6
- cgroups: don't rely on absolute path · 14637407
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  14637407
- cgroups: be stricter when creating payloads · f5eccee1
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  f5eccee1
- cgroups: rework cgroup tree creation · 5ff6d751
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  5ff6d751
- cgroups: ensure leaf cgroup is correctly pruned on creation failure · 5fb9efeb
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  5fb9efeb
- cgroups: rework cgroup tree removal on creation failure · a291dc9c
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  a291dc9c
- cgroups: remove obsolote check · 9d14f691
  Christian Brauner authored Feb 17, 2021
```
In the new layout we don't need to do this.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  9d14f691
- cgroups: reorder function arguments · a5c543e7
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  a5c543e7
- start: delegate than move into the target cgroup · 4f284640
  Christian Brauner authored Feb 17, 2021
```
This is a way more sensible model.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  4f284640
- cgroups: rework unified controller delegation · 380facc9
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  380facc9
- cgroups: check correct variable · 9c0e2c57
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  9c0e2c57
- cgroups: s/openat()/open_at()/g · e7fa53de
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  e7fa53de
- cgroups: remove obsolote cgroup_tree handling · f7cea123
  Christian Brauner authored Feb 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  f7cea123
- cgroups: fd-only cgroup tree pruning · e2e4e44c
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  e2e4e44c
- file_utils: move dup_cloexec() to header · 8f535705
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  8f535705
- cgroups: prevent double-close · 971c1e7c
  Christian Brauner authored Feb 16, 2021
```
Fixes: Coverity 1473183
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  971c1e7c
- namespace: add missing \0 terminator · 99193529
  Christian Brauner authored Feb 16, 2021
```
Link: https://launchpadlibrarian.net/523195972/buildlog_ubuntu-groovy-ppc64el.lxc_1%3A4.0.6+master~20210215-1740-0ubuntu1~groovy_BUILDING.txt.gzSigned-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  99193529
- cgroups: rework how hierarchies are added · 1f7db633
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  1f7db633
- cgroups: fix fd leaks · 63a7a2ac
  Christian Brauner authored Feb 16, 2021
```
They didn't really matter because we want to keep them around for as long as
the container lives anyway.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  63a7a2ac
- cgroups: allow "" base cgroup paths · 47f56e94
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  47f56e94
- string_utils: handle empty strings in must_make_path() · 102e9196
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  102e9196
- cgroups: improve logging · 6d0834be
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  6d0834be
- cgroups: rework legacy cpuset handling · 5582532d
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  5582532d
- cgroups: fd-based only cgroup creation · b7b1e3a3
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  b7b1e3a3