Skip to content

L
lxc
Switch branch/tag
  1. 08 Dec, 2020 27 commits
  3. 07 Dec, 2020 3 commits
  5. 02 Dec, 2020 2 commits
    • Merge pull request #3589 from tych0/fix-nonet-cleanup · 065d331a
      Stéphane Graber authored 
      network: fix LXC_NET_NONE cleanup
    • network: fix LXC_NET_NONE cleanup · 04213960
      Tycho Andersen authored 
      We have a case where we have a nested container with LXC_NET_NONE run
inside a container that's *also* got no network namespace (run by
lxc-usernsexec).

The "am I root" check in this function then does not suffice, since the
euid of the task is 0 but it does not have privilege over its network
namespace, and thus cannot do any of the restore operations:

lxc foo 20201201232059.271 TRACE    network - network.c:lxc_restore_phys_nics_to_netns:3299 - Moving physical network devices back to parent network namespace
lxc foo 20201201232059.271 ERROR    network - network.c:lxc_restore_phys_nics_to_netns:3307 - Operation not permitted - Failed to enter network namespace
lxc foo 20201201232059.271 ERROR    start - start.c:__lxc_start:2045 - Failed to move physical network devices back to parent network namespace

Let's check that we indeed did clone the network namespace, and thus have
things to restore to their correct namespace before attempting to actually
restore them.

I suspect it's possible we can also get rid of some of the network namespace
preservation stuff in start.c in the LXC_NET_NONE case.
Signed-off-by: 's avatarTycho Andersen <tycho@tycho.pizza>
  7. 21 Nov, 2020 2 commits
  9. 18 Nov, 2020 2 commits
  11. 17 Nov, 2020 2 commits
  13. 16 Nov, 2020 2 commits