Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Calculate length only once.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cmd: lxc-user-nic: change log macro & cleanups

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: fix lxc-execute command parsing

storage/loop.c: integer overflow

The issue was introduced in PR (https://github.com/lxc/lxc/pull/1705):

Previous code:
```
  if (lseek(fd, size, SEEK_SET) < 0) {
    SYSERROR("Error seeking to set new loop file size");
    close(fd);
    return -1;
  }
```
New code:
```
  int fd, ret;

  [...]

  ret = lseek(fd, size, SEEK_SET);
  if (ret < 0) {
    SYSERROR("Failed to seek to set new loop file size for loop "
       "file \"%s\"", path);
    close(fd);
    return -1;
  }
```

Based on http://man7.org/linux/man-pages/man2/lseek.2.html:
> Upon successful completion, lseek() returns the resulting offset
> location as measured in bytes from the beginning of the file.

So in this case value of `size` and `size` is `uint64_t`.

This fix change declaration of `ret`, but it can be fixed in other ways.
Let me know what works for you.

This PR fix issues (https://github.com/lxc/lxc/issues/1872).
Signed-off-by: Lukasz Jagiello <lukasz@wikia-inc.com>

Initialize buf to avoid parsing random data later on.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage_utils: move duplicated function from tools

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: add default log priority & cleanups

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

lxc_init: s/SYSDEBUG()/SYSERROR()/g in remove_self

Since we switched to execveat() whenever possible in
commit 4b5b3a2a ("execute: use execveat() syscall if supported")
it is unlikely that remove_self() has any job to do at all. So dumb down the
error levels.

Closes #2536.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cmd: Fix up checkpatch warnings

Clean up contributing and coding stlye docs

checkpatch emits two warnings of type:

    CHECK: Comparison to NULL could be written "!foo"

Prefer `(!foo)` instead of `(foo == NULL)`.

Do not use comparison to NULL, use !foo
Signed-off-by: Tobin C. Harding <me@tobin.cc>

checkpatch emits warning:

    WARNING: Statements terminations use 1 semicolon

Remove typo'd semicolon.
Signed-off-by: Tobin C. Harding <me@tobin.cc>

checkpatch emits warning:

    WARNING: Block comments use a trailing */ on a separate line

Put trailing */ on a separate line.
Signed-off-by: Tobin C. Harding <me@tobin.cc>

checkpatch emits warning:

    WARNING: unnecessary whitespace before a quoted newline

Remove unnecessary whitespace before a quoted newline
Signed-off-by: Tobin C. Harding <me@tobin.cc>

checkpatch emits warning:

WARNING: static char array declaration should probably be static const char

Use 'const' for static string constant (array of chars).
Signed-off-by: Tobin C. Harding <me@tobin.cc>

checkpatch warns about a bunch of whitespace issues.  Fix the
non-controversial ones.

Fix whitespace issues found by checkpatch.
Signed-off-by: Tobin C. Harding <me@tobin.cc>

checkpatch emites warning:

    WARNING: braces {} are not necessary for single statement blocks

Do not use braces for single statement block.
Signed-off-by: Tobin C. Harding <me@tobin.cc>