The problem here is that these two clauses were ordered backwards: we first
check if the signal came from not the init pid, and if it did, then we give
a notice and return. The comment notes that this is intended to protect
against SIGCHLD, but we don't in fact know if the signal is a SIGCHLD yet,
because that's tested in the next hunk.

The symptom is that if I e.g. send SIGTERM from the outside world to the
container init, it ignores it and gives this notice. If we re-order these
clauses, it forwards non SIGCHLD signals, and ignores SIGCHLD signals from
things that aren't the real container process.
Signed-off-by: Tycho Andersen <tycho@tycho.ws>

Signed-off-by: KATOH Yasufumi <karma@jazz.email.ne.jp>

Signed-off-by: Fengtu Wang <wangfengtu@huawei.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

If they aren't available fallback to BSD flock()s.

Closes #2245.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>

Don't use the -r option of jq, since it will strip the double quotes.

Fixes: #2195
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>

Closes #2241.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Closes #2242.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Allow passing action scripts to CRIU

Closes #2236.
Signed-off-by: Eytan Heidingsfeld <eytanh@gmail.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

configure.ac: Support redhatenterpriseserver

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

start: always make us dumpable

Otherwise lxc.hook.mount hooks that try to inspect /proc/<pid>/*
will fail.

Cc: Jonathan Calmels <jcalmels@nvidia.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: simplify autodev

This function was way more syscall heavy than it needed to be.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

hooks: fix dhclient hook when an AppArmor profile is active

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

lxccontainer: truncate config file

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

pam: Fix missing symbols in module

Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Rename ifup/down and remove usless parameter passing

remove leading whitespace from log files

Signed-off-by: Felix <de-ch@hotmail.de>

This has annoyed me for a long time, 3.0 seems like the time to fix it :).

I think the way that the log prefix was intended to be used was perhaps a
dynamic prefix per file, but we don't do that today; we include the
filename later in the log message. Instead, we use it as the tool name,
which for liblxc is always "lxc", but could also be things like
"lxc-cgroup" or whatever. There is absolutely no reason to pad this, since
it is always the same for every log file (in fact, we could probably get
rid of the prefix all together, but that seems slightly more drastic).

Instead, let's just drop this padding. Hopefully this will save thousands
of hours of slight annoyance and right scrolling in various pastebins.
Signed-off-by: Tycho Andersen <tycho@tycho.ws>

NVIDIA hook improvements

The "display" driver capability will expose /dev/nvidia-modeset:
https://github.com/NVIDIA/libnvidia-container/commit/9398d41d9f571578d6543703d287b014bcf1bb8c

The "--ldcache" argument allows overriding the location of the DSO cache:
https://github.com/NVIDIA/libnvidia-container/commit/41656bf9ed71448972f3254a10ceb3c53225a4e6

The "--root" argument allows nvidia-container-cli to execute in a different rootfs:
https://github.com/NVIDIA/libnvidia-container/commit/019fdc14e325eea55fbe0397a581bda9d0c4c5b1Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>

For a reason that I don't understand, the profile transition needs to
be done on the current process. Changing the attributes for a
subsequent execve(2) (with /proc/self/attr/exec) will cause the kernel
to set AT_SECURE in the auxiliary vector and thus secure_getenv(3)
inside libnvidia-container will return NULL.
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

tools: fix container use-after-free

Fields daemonize and error_num were being called after the
lxc_container_put.
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>

doc: Remove aufs in Japanese man pages

* and tweak English lxc-copy(1)
Signed-off-by: KATOH Yasufumi <karma@jazz.email.ne.jp>

tree-wide: remove aufs storage driver

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>